Update javascript.js to better match javascript(embedded) in all themes#17347
Update javascript.js to better match javascript(embedded) in all themes#17347pryrt wants to merge 5 commits intonotepad-plus-plus:masterfrom
Conversation
| <WordsStyle name="USER KEYWORDS 8" styleID="135" fgColor="FF6600" bgColor="000000" fontName="" fontStyle="1" fontSize="" keywordClass="substyle8" /> | ||
| <WordsStyle name="PREPROCESSOR COMMENT" styleID="23" fgColor="FFFFFF" bgColor="000000" fontName="" fontStyle="0" fontSize="" /> | ||
| <WordsStyle name="PREPROCESSOR COMMENT DOC" styleID="24" fgColor="FFFFFF" bgColor="000000" fontName="" fontStyle="0" fontSize="" /> | ||
| <WordsStyle name="PREPROCESSOR" styleID="9" fgColor="C0C0C0" bgColor="000000" fontName="" fontStyle="0" fontSize=""></WordsStyle> |
There was a problem hiding this comment.
Deep Black.xml and vim Dark Blue.xml contain unneeded changes
There was a problem hiding this comment.
Now it is missing space before "/>"
There was a problem hiding this comment.
I saw that, and was already fixing it.
| Official Vim Zenburn home page: http://kippura.org/zenburnpage/ | ||
| Supported languages: All the languages supported by release 7.7 | ||
| Created by: Jani Kesänen (jani dot kesanen gmail com) | ||
| Created by: Jani Kesänen (jani dot kesanen gmail com) |
There was a problem hiding this comment.
Due to failed encoding conversion this will increase file size.
Could you fix it by using Jani Kesänen.
There was a problem hiding this comment.
Unfortunately changing style in in styler will again trigger this corruption. So it seems that upgrade to tinyxml2 will be needed.
There was a problem hiding this comment.
That's beyond the scope of this PR, obviously. ;-)
I assumed you'd be getting to that eventually, since you've been working on converting the other XML processing to tinyxml2. :-) (When you do get around to implementing that, make sure you see whether tinyxml2 has an option to make newlines consistent between the main file and comments, because it's tinyxml1 that caused the comment:LF-vs-document:CRLF difference from your first comment to this PR.)
There was a problem hiding this comment.
it should be ok, with _wfopen_s tinyxml2 should save file with CRLF
|
@pryrt |
per notepad-plus-plus#17347 (comment), need to specially handle the colors for old themes that were missing JavaScript.js, otherwise users will think that N++ broke their themes (which used to work due to the magic handling of missing-JavaScript.js-uses-embedded-JavaScript-lexer)
per #17347 (comment), need to specially handle the colors for old themes that were missing JavaScript.js, otherwise users will think that N++ broke their themes (which used to work due to the magic handling of missing-JavaScript.js-uses-embedded-JavaScript-lexer) Fix #17347 (comment) Close #17409
per https://community.notepad-plus-plus.org/post/104325 and #17299 (comment) , v8.9 surprised users of javascript.js language, because <=v8.8.8, it used "magic" to inherit styling from embedded javascript when javascript.js was missing; since v8.9 doesn't have "missing" language lexers anymore, the new default-only colors for the added javascript.js made it look like javascript.js was broken. Replicate the colors from embedded javascript to javascript.js for all themes, so that someone who upgrades from <=v8.8.8 to v8.9.1 will not get confused by javascript.js anymore.