Update Themes - JavaScript.js edge case#17409
Closed
pryrt wants to merge 2 commits intonotepad-plus-plus:masterfrom
Closed
Update Themes - JavaScript.js edge case#17409pryrt wants to merge 2 commits intonotepad-plus-plus:masterfrom
pryrt wants to merge 2 commits intonotepad-plus-plus:masterfrom
Conversation
per notepad-plus-plus#17347 (comment), need to specially handle the colors for old themes that were missing JavaScript.js, otherwise users will think that N++ broke their themes (which used to work due to the magic handling of missing-JavaScript.js-uses-embedded-JavaScript-lexer)
Contributor
Author
|
With this new code, I verified:
@ozone10, please confirm this works as you expect |
donho
requested changes
Jan 17, 2026
Member
donho
left a comment
There was a problem hiding this comment.
Please remove the unnecessary part.
Contributor
|
@pryrt |
donho
approved these changes
Jan 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
per #17347 (comment), need to specially handle the colors for old themes that were missing JavaScript.js, otherwise users will think that N++ broke their themes (which used to work due to the magic handling of missing-JavaScript.js-uses-embedded-JavaScript-lexer)