Skip to content

Use the post-v8.8.9 code to update all the themes#17299

Closed
pryrt wants to merge 2 commits intonotepad-plus-plus:masterfrom
pryrt:themesPost889
Closed

Use the post-v8.8.9 code to update all the themes#17299
pryrt wants to merge 2 commits intonotepad-plus-plus:masterfrom
pryrt:themesPost889

Conversation

@pryrt
Copy link
Contributor

@pryrt pryrt commented Dec 12, 2025

All 22 themes should now have every language and every WordsStyle/WidgetStyle mentioned in the stylers.model.xml, using 'sane' colors for the new entries, so none have glaring white background

addresses #17289 (comment)

All 22 themes should now have every language and every WordsStyle/WidgetStyle mentioned in the stylers.model.xml, using 'sane' colors for the new entries, so none have glaring white background
@chcg chcg added enhancement Proposed enhancements of existing features theme theming related issues labels Dec 14, 2025
@donho donho self-assigned this Dec 15, 2025
@donho donho closed this in dcc2f42 Dec 15, 2025
@pryrt pryrt deleted the themesPost889 branch December 15, 2025 23:50
@ozone10
Copy link
Contributor

ozone10 commented Dec 28, 2025

@pryrt
each missing languages will have same colors for background which is ok, but the issue is with highlighting for text. For user the same colors is same as having normal text style, which can cause confusion.

Also for javascript, because its style was missing instead embedded variant style was used, but now it will use this "two" colors style so the syntax highlighting is lost.

@pryrt
Copy link
Contributor Author

pryrt commented Dec 28, 2025

each missing languages will have same colors for background which is ok, but the issue is with highlighting for text. For user the same colors is same as having normal text style, which can cause confusion.

That was the decision that was made, in order to give this new feature. I didn't know about the JS exception until a few minutes ago. But except for JavaScript, there won't be an experiential difference for a user of v8.8.8 vs v8.9 for any other language in the dark themes, except that before they couldn't use Style Configurator to change the colors in those languages, and now they can: A user of v8.8.8 would have seen default-foreground on default-background for a language that wasn't in their theme, and they couldn't change it without editing raw XML. A user of v8.9 will still see default-foreground on default-bakground for a language that didn't used to be in their theme, but now they can easily change it in the Style Configurator. How is that something to complain about, instead of being regarded as a drastic improvement to the situation? And since the initial behavior is exactly the same to the user, how can that in any way be considered "confusing"?

The JavaScript "magic" blindsided me. I didn't know there was a magic piece of code that would use the embedded-js colors if the javascript.js styles didn't exist. I can go try to manually propagate the colors from the js-embedded to their equivalent styles in the javascript.js, so that the next batch will have better colors for javascript.js. But every other missing language is a drastic improvement.

@ozone10
Copy link
Contributor

ozone10 commented Dec 28, 2025

Yes it is good improvement. For confusion I mean mainly for javascript, for user if they change from style which has highlighting to style without it.

@pryrt
Copy link
Contributor Author

pryrt commented Dec 28, 2025

Yeah, I will work on replicating the javascript-embedded colors to javascript.js for the themes that don't have good colors already, and do a new PR for that. It won't do anything for v8.9, obviously, but it will help javascript users in future versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Proposed enhancements of existing features theme theming related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants