Skip to content

Fix White flash on Npp startup in darkmode#10639

Closed
Ashfaaq18 wants to merge 1 commit intonotepad-plus-plus:masterfrom
Ashfaaq18:WhiteflashInDarkmode_fix
Closed

Fix White flash on Npp startup in darkmode#10639
Ashfaaq18 wants to merge 1 commit intonotepad-plus-plus:masterfrom
Ashfaaq18:WhiteflashInDarkmode_fix

Conversation

@Ashfaaq18
Copy link
Contributor

@Ashfaaq18 Ashfaaq18 commented Oct 8, 2021

fix #3955 and fix #10601

This is currently set to work only on darkmode.
Btw @xomx, feel free to test it and let me know if its fine.

before fix on startup:

backlight_fix_before2

after fix on startup:

backlight_fix_after1

@xomx
Copy link
Contributor

xomx commented Oct 8, 2021

Yep, it is working, good work.

@Yaron10
Copy link

Yaron10 commented Oct 9, 2021

@Ashfaaq18,

👍
I've just tested it for this PR (I do not use Dark Mode).
Very nice. Thank you for your work.

@chcg chcg added the dark mode Dark mode related issues, fixes label Oct 10, 2021
@donho donho self-assigned this Oct 10, 2021
@donho donho added the accepted label Oct 10, 2021
@donho donho closed this in 35e3fb9 Oct 10, 2021
@donho
Copy link
Member

donho commented Oct 10, 2021

@Ashfaaq18
Just recheck this PR, #10601 has been fixed indeed. But how does this PR fix #3955 (in light mode) ?

@Ashfaaq18
Copy link
Contributor Author

@donho, true. The thing is, during the #3955 issue period, Npp did not have dark mode implemented if I'm right.
The user's issue expected behavior is as follows

Expected Behavior

Notepad++ should default shine in the color of the global settings. If not that, at least a dark grey or black even. Every time I
open NPPP I get this really white flash shone at me. I use dark themes.

Because there was no dark mode (the user used dark theme at the time), They wanted the background color of the global setting or at least dark grey/black.

But now we have dark mode, and almost everyone who is worried about this white flash is/was using a dark theme.
Its because of this sudden contrast change from white startup to dark background the problem arises.

But if required I can try changing the code to the current loaded theme background color. This way, the startup background color will be independent from dark mode and dependent on the theme's background color.

Or

If @donho and anyone else have any other ideas on what startup colors to apply, please do comment here.

@donho
Copy link
Member

donho commented Oct 10, 2021

@Ashfaaq18

But if required I can try changing the code to the current loaded theme background color. This way, the startup background color will be independent from dark mode and dependent on the theme's background color.

It's OK - I just want to make chang log on release page more accurate.
We will see if it needs to enhance this part more.
Thank you for the explanation and especially for the fix.

@Wehrmachtserdbeere
Copy link

Please post the code, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted dark mode Dark mode related issues, fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opening NotePad++ in Dark mode flashes a bright white screen before darkening NPPP Flashes Default White On Open

6 participants