Skip to content

[2.7] bpo-30850: test_bsddb3 tolerates smaller timeout on Windows #2840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 1 commit into from
Jul 24, 2017
Merged

[2.7] bpo-30850: test_bsddb3 tolerates smaller timeout on Windows #2840

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Lib/bsddb/test/test_lock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
TestCases for testing the locking sub-system.
"""

import sys
import time

import unittest
Expand All @@ -10,7 +11,6 @@

if have_threads :
from threading import Thread
import sys
if sys.version_info[0] < 3 :
from threading import currentThread
else :
Expand Down Expand Up @@ -129,7 +129,14 @@ def deadlock_detection() :
end_time=time.time()
deadlock_detection.end=True
# Floating point rounding
self.assertGreaterEqual(end_time-start_time, 0.0999)
if sys.platform == 'win32':
# bpo-30850: On Windows, tolerate 50 ms whereas 100 ms is expected.
# The lock sometimes times out after only 58 ms. Windows clocks
# have a bad resolution and bad accuracy.
min_dt = 0.050
else:
min_dt = 0.0999
self.assertGreaterEqual(end_time-start_time, min_dt)
self.env.lock_put(lock)
t.join()

Expand Down