This repository was archived by the owner on Aug 7, 2021. It is now read-only.
feat: stop using the proxy tns-core-modules package when the @nativescript/core is available#1093
Merged
DimitarTachev merged 2 commits intomasterfrom Nov 21, 2019
Merged
Conversation
…vescript/core` is available
Contributor
Author
|
test cli-smoke cli-templates cli-plugin cli-preview cli-tests cli-vue cli-build cli-debug cli-device cli-run webpack-apps |
1 similar comment
Contributor
|
test cli-smoke cli-templates cli-plugin cli-preview cli-tests cli-vue cli-build cli-debug cli-device cli-run webpack-apps |
Contributor
|
test cli-smoke cli-templates cli-plugin cli-preview cli-tests cli-vue cli-debug cli-device cli-run |
Contributor
|
test cli-templates cli-preview cli-test cli-vue cli-debug cli-device cli-run |
1 similar comment
Contributor
|
test cli-templates cli-preview cli-test cli-vue cli-debug cli-device cli-run |
…script/core is at the root of node_modules
Contributor
|
test cli-smoke cli-templates cli-plugin cli-preview cli-tests cli-vue cli-build cli-debug cli-device cli-run webpack-apps |
Fatme
approved these changes
Nov 21, 2019
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
It's not possible to use the plugin without the
tns-core-modulesproxy package because we injecttns-core-modulesrequire statements in the app.What is the new behavior?
The plugin injects the require statements based on the
@nativescript/corepackage availability.P.S. The PR is based on the @DickSmith's proposal in this PR with two additional improvements.
Related to: #1089