Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

chore: fix for missing redirects on @nativescript/angular#1088

Closed
DickSmith wants to merge 1 commit intoNativeScript:masterfrom
DickSmith:master
Closed

chore: fix for missing redirects on @nativescript/angular#1088
DickSmith wants to merge 1 commit intoNativeScript:masterfrom
DickSmith:master

Conversation

@DickSmith
Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

ERROR in __REDACTED__/node_modules/@nstudio/nativescript-checkbox/angular/index.js
Module not found: Error: Can't resolve 'nativescript-angular/forms/value-accessors/base-value-accessor' in '__REDACTED__/node_modules/@nstudio/nativescript-checkbox/angular'
ERROR in __REDACTED__/node_modules/nativescript-drop-down/angular/index.js
Module not found: Error: Can't resolve 'nativescript-angular/forms/value-accessors/base-value-accessor' in '__REDACTED__/node_modules/nativescript-drop-down/angular'
ERROR in __REDACTED__/node_modules/@nstudio/nativescript-checkbox/angular/index.js
Module not found: Error: Can't resolve 'nativescript-angular/lang-facade' in '__REDACTED__node_modules/@nstudio/nativescript-checkbox/angular'

What is the new behavior?

From what I've seen for the @nativescript/angular package, all mappings should be 1-1 anyway, so this should work, any exceptions to that assumption can also be remapped here for the specific cases.
Fixes/Implements/Closes:
nstudio/nativescript-checkbox#118
PeterStaev/NativeScript-Drop-Down#229

@rosen-vladimirov
Copy link
Copy Markdown
Contributor

Closing as the suggested changes were already merged in this PR
Thanks for the great idea @DickSmith

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants