Greptile Summary

This PR cleans up the Uniswap4 class by removing the now-redundant version parameter (and all the if self.version == 4 / else: raise ValueError branches), fixing several real bugs, and tidying up observability. It also correctly relocates pre-commit to dev-dependencies in pyproject.toml.

Key changes:

• pre-commit moved to dev-dependencies — it is a developer tooling package and had no business being installed in production environments.
• version parameter and guards removed — Uniswap4 is a v4-only class; the version checks were dead code and added noise.
• Default max_slippage reduced from 0.1 (10%) to 0.01 (1%) — a safer default that reduces the risk of unexpected slippage losses for users who do not explicitly set this value.
• ETH exact-output swap value bug fixed — _token_to_token_swap_output was incorrectly sending qty (the exact output amount) as the msg.value for ETH swaps; it now correctly sends amount_in_max.
• print() → logger.info() — logging is now routed through the module logger, respecting application log configuration.
• approve() address comparison fixed — _addr_to_str(token) != ETH_ADDRESS now correctly handles AddressLike (bytes) inputs that would never have equaled the string ETH_ADDRESS.
• Stale :param version: docstring — the version parameter was removed from the signature but its docstring entry remains on line 77.
• Silent exception drop in get_token — the bare except Exception: swallows the root-cause exception; prefer raise InvalidToken(address) from e to preserve the original traceback.

Confidence Score: 4/5

• Safe to merge after addressing the stale docstring and re-adding exception chaining in get_token; no critical regressions introduced.
• The bulk of changes are straightforward cleanups (removing dead version-guard branches) and genuine bug fixes. The two remaining issues are minor: a stale docstring and a swallowed exception that loses diagnostic context. No new logic errors were introduced.
• Pay close attention to uniswap/uniswap4.py around the __init__ docstring (line 77) and get_token exception handling (line 1432).

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant Caller
    participant Uniswap4
    participant Permit2
    participant ERC20
    participant Router

    Note over Uniswap4: __init__: version param removed,<br/>max_slippage default 0.1→0.01

    Caller->>Uniswap4: approve(token)
    alt token is NOT ETH (fixed: uses _addr_to_str comparison)
        Uniswap4->>ERC20: approve(permit2_address, max_approval)
        ERC20-->>Uniswap4: tx
        Note over Uniswap4: sleep(7s)
    end
    Uniswap4->>Permit2: approve(token, router_address, max_approval, expiration)
    Permit2-->>Uniswap4: tx
    Uniswap4-->>Caller: tx hash

    Caller->>Uniswap4: _token_to_token_swap_output(input=ETH, qty, qtycap)
    Note over Uniswap4: amount_in_max = (1 + slippage) * qtycap<br/>BUG FIX: ether_amount = amount_in_max (was qty)
    Uniswap4->>Router: execute(commands, [exact_out_params], deadline)<br/>value = amount_in_max
    Router-->>Uniswap4: tx hash
    Uniswap4-->>Caller: tx hash

_{Last reviewed commit: "review fixes"}