Adds an optimization in case when a single number is passed to encode#49
Merged
manigandham merged 1 commit intoullmark:masterfrom Mar 24, 2022
dompagoj:feature/single-number-optimization
Merged
Adds an optimization in case when a single number is passed to encode#49manigandham merged 1 commit intoullmark:masterfrom dompagoj:feature/single-number-optimization
manigandham merged 1 commit intoullmark:masterfrom
dompagoj:feature/single-number-optimization
Conversation
Collaborator
|
Looks good, thanks @dompagoj |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I figured that by far the most used case is passing a single number to the Encode function, so i added a very small optimization to it, performance is about the same, but memory consumtion is close to 3x less.