Skip to content

Rename onFullData to accumulateBody#1239

Draft
Copilot wants to merge 2 commits intomasterfrom
copilot/rename-onfull-data-to-accumulatebody
Draft

Rename onFullData to accumulateBody#1239
Copilot wants to merge 2 commits intomasterfrom
copilot/rename-onfull-data-to-accumulatebody

Conversation

Copy link
Contributor

Copilot AI commented Mar 12, 2026

Renames the HTTP response body accumulation method from onFullData to accumulateBody for a more descriptive, verb-first API.

Changes

  • src/HttpResponseWrapper.h: Renamed res_onFullDatares_accumulateBody; updated prototype registration string "onFullData""accumulateBody"
  • docs/index.d.ts: Updated TypeScript signature accordingly

Usage

res.accumulateBody(1024 * 1024, (body) => {
  if (!body) {
    res.writeStatus('413').end();
    return;
  }
  // body is ArrayBuffer with complete request body
});

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Co-authored-by: uNetworkingAB <110806833+uNetworkingAB@users.noreply.github.com>
Copilot AI changed the title [WIP] Rename onFullData to accumulateBody Rename onFullData to accumulateBody Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants