Ensure equal versions have equal hashes#283
Merged
tomschr merged 3 commits intopython-semver:masterfrom Oct 20, 2020
sbrudenell:master
Merged
Ensure equal versions have equal hashes#283tomschr merged 3 commits intopython-semver:masterfrom sbrudenell:master
tomschr merged 3 commits intopython-semver:masterfrom
sbrudenell:master
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the python datamodel,
a == bimplieshash(a) == hash(b). The current implementation ofVersionInfo.__hash__includes the build, which isn't used for equality.