bpo-26552: Close dangling coroutine or future if loop is closed#30287
Closed
carlosdmz wants to merge 2 commits intopython:mainfrom
Closed
bpo-26552: Close dangling coroutine or future if loop is closed#30287carlosdmz wants to merge 2 commits intopython:mainfrom
carlosdmz wants to merge 2 commits intopython:mainfrom
Conversation
Member
|
Just curious, why'd you close this? |
Contributor
Author
|
I didn't think my approach was that good, and I was supposed to start over since I was not too happy about it. If you have any thoughts on this, I'm happy to reinstate it. |
Member
|
Oh, that’s all right, I was just wondering. There’s another PR for the same issue now, could you look at that maybe? |
Contributor
Author
|
Yes, sure. I'll leave this closed and will refer to the other PR. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue26552
With this small patch, the
RuntimeErrorexception is raised withoutRuntimeWarningsince the task is closed.