Skip to content

bpo-45375: Fix assertion failure due to searching for stdlib in unnormalised paths#28735

Merged
zooba merged 3 commits intopython:mainfrom
zooba:bpo45375
Oct 5, 2021
Merged

bpo-45375: Fix assertion failure due to searching for stdlib in unnormalised paths#28735
zooba merged 3 commits intopython:mainfrom
zooba:bpo45375

Conversation

@zooba
Copy link
Copy Markdown
Member

@zooba zooba commented Oct 5, 2021 •
edited by bedevere-bot
Loading

Also ensures that when Python is run as part of build, it can locate the library in the source tree even when built out of tree.

https://bugs.python.org/issue45375

@zooba zooba requested a review from a team as a code owner October 5, 2021 12:06
pablogsal
pablogsal approved these changes Oct 5, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed the C code, but unfortunately I am not acquainted with the semantics of this to understand if they are correct.

@zooba
Copy link
Copy Markdown
Member Author

zooba commented Oct 5, 2021

I am not acquainted with the semantics of this to understand if they are correct

That's the problem with all of getpath - nobody is! 😂 At least it's only an alpha right now, and we'll likely work more on it before beta.

@zooba zooba merged commit 5146877 into python:main Oct 5, 2021
@zooba zooba deleted the bpo45375 branch October 5, 2021 12:37
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Oct 5, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x has failed when building commit 5146877.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/725/builds/71) and take a look at the build logs.
  4. Check if the failure is related to this commit (5146877) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/725/builds/71

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

408 tests OK.

10 slowest tests:

  • test_concurrent_futures: 3 min 32 sec
  • test_multiprocessing_spawn: 2 min 34 sec
  • test_multiprocessing_forkserver: 1 min 51 sec
  • test_unparse: 1 min 30 sec
  • test_asyncio: 1 min 15 sec
  • test_tokenize: 1 min 14 sec
  • test_nntplib: 1 min 1 sec
  • test_lib2to3: 59.6 sec
  • test_logging: 57.5 sec
  • test_capi: 55.6 sec

1 test altered the execution environment:
test_ftplib

16 tests skipped:
test_devpoll test_epoll test_gdb test_ioctl test_msilib
test_multiprocessing_fork test_ossaudiodev test_spwd
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

Total duration: 8 min 57 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_a3a255ad'


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_c5b4c58b'


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 90, in read
    obj.handle_read_event()
    ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 384, in handle_read_event
    self._do_ssl_handshake()
    ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 345, in _do_ssl_handshake
    self.socket.do_handshake()
    ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/ssl.py", line 1346, in do_handshake
    self._sslobj.do_handshake()
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
ssl.SSLZeroReturnError: TLS/SSL connection has been closed (EOF) (_ssl.c:998)


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/threading.py", line 1031, in _bootstrap_inner
    self.run()
    ^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 298, in run
    asyncore.loop(timeout=0.1, count=1)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 214, in loop
    poll_fun(timeout, map)
    ^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 157, in poll
    read(obj)
    ^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 94, in read
    obj.handle_error()
    ^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 421, in handle_error
    raise Exception
    ^^^^^^^^^^^^^^^
Exception

eryksun
eryksun reviewed Oct 5, 2021
View reviewed changes
PC/getpathp.c

if (FAILED(PathCchCanonicalizeEx(buffer, MAXPATHLEN + 1, path, 0))) {
if (PathIsRelativeW(path)) {
wchar_t buff[MAXPATHLEN];
Copy link
Copy Markdown
Contributor

@eryksun eryksun Oct 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allocation should be MAXPATHLEN + 1. In this file, MAXPATHLEN refers to the string length of the path, without the terminating null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eryksun eryksun eryksun left review comments

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

OS-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zooba @bedevere-bot @eryksun @pablogsal @the-knights-who-say-ni