Skip to content

bpo-43008: Make IDLE respect sys.excepthook#24302

Merged
terryjreedy merged 6 commits intopython:masterfrom
Kenny2github:patch-1
Jan 26, 2021
Merged

bpo-43008: Make IDLE respect sys.excepthook#24302
terryjreedy merged 6 commits intopython:masterfrom
Kenny2github:patch-1

Conversation

@Kenny2github
Copy link
Copy Markdown
Contributor

@Kenny2github Kenny2github commented Jan 23, 2021 •
edited by terryjreedy
Loading

This applies to default 2-process mode as excepthook already works in -n mode.

https://bugs.python.org/issue43008

@Kenny2github
Copy link
Copy Markdown
Contributor Author

Kenny2github commented Jan 23, 2021 •
edited
Loading

CLA signed, it'll take a bit to update tho.
Also, not sure if news is necessary - lmk if it is.

terryjreedy
terryjreedy previously approved these changes Jan 23, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I answered on the issue what is required and desired.
Recording of CLA is also required. Won't happen before Monday at earliest.

@terryjreedy terryjreedy dismissed their stale review January 23, 2021 15:30

Meant to say change required.

terryjreedy
terryjreedy requested changes Jan 23, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@terryjreedy terryjreedy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of issue post. Require

  1. Guard excepthook call, imitating standard result of excepthook exception.
  2. Short blurb.
  3. Minor doc change.
    Want
  4. Tests

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jan 23, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Kenny2github
Add blurb for IDLE fix
4c891b5
@Kenny2github
Update IDLE Restart Shell docs to say...
237be53 
..." and reset display and exception handling".
@Kenny2github
IDLE: Handle sys.excepthook errors...
a11fa37 
...when raising in 2-process mode, in a way that matches normal shell behavior.
@Kenny2github
Copy link
Copy Markdown
Contributor Author

Kenny2github commented Jan 23, 2021

Besides the tests, I have made the requested changes; please review again. I didn't manage to figure out how to go about testing an excepthook in the first place, let alone a good or bad one. Hope that's not an issue.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jan 23, 2021

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

@python python deleted a comment from the-knights-who-say-ni Jan 26, 2021
@terryjreedy terryjreedy added needs backport to 3.8 type-bug An unexpected behavior, bug, or error labels Jan 26, 2021
@terryjreedy terryjreedy merged commit 7a34380 into python:master Jan 26, 2021
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jan 26, 2021

Thanks @Kenny2github for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jan 26, 2021

GH-24346 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 26, 2021
@Kenny2github @miss-islington
bpo-43008: Make IDLE respect sys.excepthook (pythonGH-24302)
142c3c6 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 7a34380)

Co-authored-by: Ken <kenny2minecraft@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 26, 2021
@Kenny2github @miss-islington
bpo-43008: Make IDLE respect sys.excepthook (pythonGH-24302)
7669811 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 7a34380)

Co-authored-by: Ken <kenny2minecraft@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jan 26, 2021

GH-24347 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jan 27, 2021
@miss-islington @Kenny2github
bpo-43008: Make IDLE respect sys.excepthook (GH-24302)
68102fb 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 7a34380)

Co-authored-by: Ken <kenny2minecraft@gmail.com>
miss-islington added a commit that referenced this pull request Jan 27, 2021
@miss-islington @Kenny2github
bpo-43008: Make IDLE respect sys.excepthook (GH-24302)
6f0346d 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 7a34380)

Co-authored-by: Ken <kenny2minecraft@gmail.com>
@python python deleted a comment from bedevere-bot Jan 27, 2021
@terryjreedy
Copy link
Copy Markdown
Member

terryjreedy commented Jan 27, 2021

Deleted bogus buildbot splat: test_asyncio altered the execution environment.

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@Kenny2github @terryjreedy @adorilson
bpo-43008: Make IDLE respect sys.excepthook (pythonGH-24302)
adffbb9 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
This was referenced Nov 28, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Kenny2github @bedevere-bot @miss-islington @terryjreedy @the-knights-who-say-ni