Skip to content

bpo-42229: Fix SQLite warnings on macOS #23072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SamuelMarks wants to merge 1 commit into from
Closed

bpo-42229: Fix SQLite warnings on macOS #23072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Modules/_sqlite/connection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@
#define ACTION_FINALIZE 1
#define ACTION_RESET 2

#if SQLITE_VERSION_NUMBER >= 3014000
#if SQLITE_VERSION_NUMBER >= 3014000 || \
defined(__APPLE__) && defined(__MACH__) \
&& __MAC_OS_X_VERSION_MIN_REQUIRED >= __MAC_10_12
Comment on lines +36 to +38
Copy link
Copy Markdown
Contributor

@erlend-aasland erlend-aasland Nov 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail if you're compiling against SQLite pre 3.14 on macOS. One cannot assume that all macOS builds uses the SQLite 3 that's shipped with the OS.

Copy link
Copy Markdown
Contributor Author

@SamuelMarks SamuelMarks Nov 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should check in the configure; and set the HAVE_TRACE_V2 there?

#define HAVE_TRACE_V2
#endif

Expand Down