bpo-41735: Fix thread locks in zlib module may go wrong in rare case.#22126
Conversation
Setting `next_in` before acquiring the thread lock may mix up compress/decompress state in other threads.
Member
|
Can you add a unit test that fails without the fix and passes with it? |
Author
Run this code: import zlib
import threading
with open('txt.tar', 'rb') as f:
b = f.read()
b = b[:100*1024*1024]
print('read', len(b))
cobj = zlib.compressobj()
def f(name, cobj, b):
print(name)
dat = cobj.compress(b)
print(name, len(dat))
thread1 = threading.Thread(target=f, args=('T1', cobj, b))
thread2 = threading.Thread(target=f, args=('T2', cobj, b))
thread1.start()
thread2.start()
print('ok')Before the patch, output: It seems thread2 did not finish the compressing. After the patch, output: |
Author
Seems a little troublesome. If the data is large, it may be time-consuming. If the data is small, it may not trigger the bug. Above code can reliably reproduce the bug. |
ambv
reviewed
Apr 26, 2021
|
@ambv: Please replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41735