Use standard integer types instead of Python aliases#15659
Closed
sir-sigurd wants to merge 2 commits intopython:masterfrom
Closed
Use standard integer types instead of Python aliases#15659sir-sigurd wants to merge 2 commits intopython:masterfrom
sir-sigurd wants to merge 2 commits intopython:masterfrom
Conversation
Contributor
Author
|
Should we leave this for compatibility? Lines 73 to 78 in 132acab |
sir-sigurd
commented
Sep 3, 2019
| /* 64bit platforms with unsigned int64 */ | ||
| typedef PY_UINT64_T UINT64; | ||
| typedef unsigned char UINT8; | ||
| typedef uint64_t UINT64; |
Contributor
Author
There was a problem hiding this comment.
Probably we can remove these typedefs and restore the original ones?
cpython/Modules/_sha3/kcp/KeccakP-1600-opt64.c
Lines 21 to 24 in 132acab
Contributor
You can always open a new issue and then reference the old issue in the description. :-) |
Contributor
Author
Member
It's just that I noticed a few remainaing PY_INT64_T types while working on https://bugs.python.org/issue40302 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd attribute this to the old issue, but for some reason, some developers seem to be annoyed by using old issues.