Skip to content

Don't skip pickle check_frame_opcodes().#15025

Merged
nascheme merged 1 commit intopython:masterfrom
nascheme:pgo_dont_skip_pickle_frame_opcodes
Jul 30, 2019
Merged

Don't skip pickle check_frame_opcodes().#15025
nascheme merged 1 commit intopython:masterfrom
nascheme:pgo_dont_skip_pickle_frame_opcodes

Conversation

@nascheme
Copy link
Copy Markdown
Member

This looks like the only place that proto 4 framing gets exercised
so leave it as part of the PGO task.

This looks like the only place that proto 4 framing gets exercised
so leave it as part of the PGO task.
@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @nascheme for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@nascheme nascheme deleted the pgo_dont_skip_pickle_frame_opcodes branch July 30, 2019 19:08
@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @nascheme for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 30, 2019
This looks like the only place that proto 4 framing gets exercised
so leave it as part of the PGO task.
(cherry picked from commit eca7ffc)

Co-authored-by: Neil Schemenauer <nas-github@arctrix.com>
@bedevere-bot
Copy link
Copy Markdown

GH-15027 is a backport of this pull request to the 3.8 branch.

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
This looks like the only place that proto 4 framing gets exercised
so leave it as part of the PGO task.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
This looks like the only place that proto 4 framing gets exercised
so leave it as part of the PGO task.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
This looks like the only place that proto 4 framing gets exercised
so leave it as part of the PGO task.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip issue skip news type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants