[3.7] bpo-27860: ipaddress: fix Interface constructor#14200
Merged
methane merged 4 commits intopython:3.7from Jun 19, 2019
Merged
[3.7] bpo-27860: ipaddress: fix Interface constructor#14200methane merged 4 commits intopython:3.7from
methane merged 4 commits intopython:3.7from
Conversation
…12836) IPv4Interface and IPv6Interface did not has netmask and hostmask attributes when its argument is bytes or int. This commit extracts method for constructors of Network and Interface, and ensure Interface class always provides them. (cherry picked from commit 6fa84bd) Signed-off-by: Inada Naoki <songofacandy@gmail.com>
asvetlov
approved these changes
Jun 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interface constructor is documented as accepts address same to Network,
but it didn't accept some form of the address.
This is backport of GH-12836 (commit 6fa84bd)
https://bugs.python.org/issue27860