bpo-27639: Slices of UserLists are instances of UserList now.#13150
Closed
serhiy-storchaka wants to merge 1 commit intopython:masterfrom
Closed
bpo-27639: Slices of UserLists are instances of UserList now.#13150serhiy-storchaka wants to merge 1 commit intopython:masterfrom
serhiy-storchaka wants to merge 1 commit intopython:masterfrom
Conversation
Patch by Dmitry Kazakov.
serhiy-storchaka
commented
May 7, 2019
| u = self.type2test(l) | ||
| self.assertIsInstance(u[:], self.type2test) | ||
| self.assertEqual(u[:], l) | ||
| self.assertIsInstance(u[::-1], self.type2test) |
Member
Author
There was a problem hiding this comment.
Added also the test for extended slices (this does not work in Python 2).
Member
|
@serhiy-storchaka do you think we could close this PR and the associated issue because #13169 has been merged into master and there is a backport (#13203) for 3.7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch by Dmitry Kazakov.
https://bugs.python.org/issue27639