Skip to content

Add a footnote about Cheese Shop in Doc/tutorial#13103

Merged
matrixise merged 3 commits intopython:masterfrom
adorilson:add_explain_cheese_shop
May 7, 2019
Merged

Add a footnote about Cheese Shop in Doc/tutorial#13103
matrixise merged 3 commits intopython:masterfrom
adorilson:add_explain_cheese_shop

Conversation

@adorilson
Copy link
Copy Markdown
Contributor

In previously versions, Brazilian team translation added a footnote explaining the origin from name Cheese Shop. We think this can be util for all languages.

@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@csabella
Copy link
Copy Markdown
Contributor

csabella commented May 6, 2019

Thank you for the pull request!

This is the Travis error:

/home/travis/build/python/cpython/Doc/tutorial/whatnow.rst:75:Explicit markup ends without a blank line; unexpected unindent.

Please correct that for the CIs to pass.

@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @adorilson for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@matrixise
Copy link
Copy Markdown
Member

Thank you so much for your contribution.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 7, 2019
(cherry picked from commit e19a91e)

Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

GH-13174 is a backport of this pull request to the 3.7 branch.

cjw296 pushed a commit that referenced this pull request May 7, 2019
(cherry picked from commit e19a91e)

Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants