bpo-36642: make unicodedata const#12855
Merged
methane merged 2 commits intopython:masterfrom Apr 16, 2019
Merged
Conversation
vstinner
approved these changes
Apr 16, 2019
Member
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
But I don't think that it deserves to be backported.
serhiy-storchaka
approved these changes
Apr 16, 2019
Member
Author
|
@benjaminp Should I update |
Member
Since the script is part of Python, I don't see the point of having a version for the tool. As the changelog, since the script is tracked in Git, I don't see the point of having a dedicated changelog (but keeping the old changelog is fine). |
Member
|
I would suggest to just remove VERSION = "3.3" from Tools/unicode/makeunicodedata.py :-) |
Contributor
|
FWIW, I agree with vstinner that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36642