Skip to content

bpo-36052: Raise a SyntaxError when we assign a value to __debug__#11958

Merged
pablogsal merged 6 commits intopython:masterfrom
matrixise:bpo-36052
Feb 21, 2019
Merged

bpo-36052: Raise a SyntaxError when we assign a value to __debug__#11958
pablogsal merged 6 commits intopython:masterfrom
matrixise:bpo-36052

Conversation

@matrixise
Copy link
Copy Markdown
Member

@matrixise matrixise commented Feb 20, 2019 •
edited
Loading

Co-authored-by: Stéphane Wirtel stephane@wirtel.be
Co-authored-by: Pablo Galindo Pablogsal@gmail.com

https://bugs.python.org/issue36052

@matrixise matrixise mentioned this pull request Feb 20, 2019
Closed
pablogsal
pablogsal requested changes Feb 20, 2019
View reviewed changes
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 20, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

pablogsal
pablogsal reviewed Feb 20, 2019
View reviewed changes
pablogsal
pablogsal approved these changes Feb 20, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for fixing this one @matrixise :)

@matrixise
Copy link
Copy Markdown
Member Author

matrixise commented Feb 20, 2019

sorry, I have to leave and will continue the fix (if there is a fix to do ;-)). See you later (+- 3hours)

pablogsal
pablogsal reviewed Feb 20, 2019
View reviewed changes
Misc/NEWS.d/next/Core and Builtins/2019-02-20-17-57-31.bpo-36052.l8lJSi.rst Outdated
@@ -0,0 +1,2 @@
Raise a SyntaxError when we try to assign a value to `__debug__` with the
Copy link
Copy Markdown
Member

@pablogsal pablogsal Feb 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thin we don't use 'we' in the docs. Maybe:

Raise a ``SyntaxError`` when assigning a value to `__debug__` using the assignment operator.

Copy link
Copy Markdown
Member Author

@matrixise matrixise Feb 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@matrixise
Copy link
Copy Markdown
Member Author

matrixise commented Feb 21, 2019

@pablogsal or @serhiy-storchaka who want to merge this PR? ;-)

@pablogsal pablogsal merged commit 3ad9167 into python:master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@matrixise @bedevere-bot @serhiy-storchaka @pablogsal @the-knights-who-say-ni