Skip to content

gh-106176: Fix reference leak in importlib/_bootstrap.py#106207

Closed
Eclips4 wants to merge 1 commit intopython:mainfrom
Eclips4:issue-106176
Closed

gh-106176: Fix reference leak in importlib/_bootstrap.py#106207
Eclips4 wants to merge 1 commit intopython:mainfrom
Eclips4:issue-106176

Conversation

@Eclips4
Copy link
Copy Markdown
Member

@Eclips4 Eclips4 commented Jun 28, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jun 28, 2023
Closed
@Eclips4
Copy link
Copy Markdown
Member Author

Eclips4 commented Jun 28, 2023

cc @sunmy2019 @vstinner @erlend-aasland

@Eclips4
Copy link
Copy Markdown
Member Author

Eclips4 commented Jun 28, 2023 •
edited
Loading

There's no tests for case which solved by #94504, so I'm somewhat unsure if this is the right solution

However, refleaks in test_concurrency and PyUnpicklerTests (which related to issue with refleaks in test_pickle on Windows) are gone.

@brettcannon
Copy link
Copy Markdown
Member

brettcannon commented Jun 28, 2023

@exarkun any opinions on this fix?

@sunmy2019
Copy link