Skip to content

gh-101819: Adapt _io.PyWindowsConsoleIO_Type to heap type#104197

Merged
erlend-aasland merged 6 commits intopython:mainfrom
erlend-aasland:isolate-io/winconsoleio
May 7, 2023
Merged

gh-101819: Adapt _io.PyWindowsConsoleIO_Type to heap type#104197
erlend-aasland merged 6 commits intopython:mainfrom
erlend-aasland:isolate-io/winconsoleio

Conversation

@erlend-aasland
Copy link
Copy Markdown
Contributor

@erlend-aasland erlend-aasland commented May 5, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 5, 2023
Closed
@erlend-aasland erlend-aasland requested review from ericsnowcurrently, kumaraditya303 and vstinner and removed request for ericsnowcurrently May 5, 2023 11:23
@vstinner
Copy link
Copy Markdown
Member

vstinner commented May 6, 2023

Is it a draft or ready for review?

@vstinner
Copy link
Copy Markdown
Member

vstinner commented May 6, 2023 

FAIL: test_no_memleak (test.test_embed.MiscTests.test_no_memleak) (frozen_modules='on', stmt='import __hello__')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\test_embed.py", line 1802, in test_no_memleak
    self.assertEqual(refs, 0, out)
AssertionError: 512 != 0 : [512 refs, 302 blocks]

It seems like there is leak somewhere.

@vstinner
Copy link