Respond to initial review

python · AlexWaygood · Apr 23, 2023 · Feb 11, 2023 · Feb 11, 2023 · Feb 11, 2023
commit 7194d3e2b53ead8ee23c811aa5db1d28772241e0
diff --git a/Doc/library/typing.rst b/Doc/library/typing.rst
@@ -2822,6 +2822,8 @@ Introspection helpers
         get_orig_bases(Bar) == (Foo[int], float)
         get_orig_bases(int) == None
 
+    .. versionadded:: 3.12
+
 .. function:: get_orig_class(tp, /)
 
     Returns the ``GenericAlias`` object that was instantiated to create ``tp``.
@@ -2838,7 +2840,10 @@ Introspection helpers
 
     .. warning::
 
-        This function will not work inside of the class initalisation process.
+        This function will always return ``None`` inside of the class initalisation
+        process.
+
+    .. versionadded:: 3.12
 
 .. function:: is_typeddict(tp)
 

diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py
@@ -5358,18 +5358,27 @@ class C(Generic[T]): pass
     def test_get_orig_class(self):
         T = TypeVar('T')
         class C(Generic[T]): pass
+        class D(C[int]): ...
+        class E(C[str], float): pass
         self.assertEqual(get_orig_class(C[int]()), C[int])
+        self.assertIsNone(get_orig_class(C()))
+        self.assertIsNone(get_orig_class(D()))
+        self.assertIsNone(get_orig_class(E()))
         self.assertIsNone(get_orig_class(list[int]()))
         self.assertIsNone(get_orig_class(int))
 
     def test_get_orig_bases(self):
         T = TypeVar('T')
+        class A: pass
+        class B(object): pass
         class C(Generic[T]): pass
         class D(C[int]): pass
         class E(C[str], float): pass
+        self.assertIsNone(get_orig_bases(A))
+        self.assertIsNone(get_orig_bases(B))
         self.assertEqual(get_orig_bases(C), (Generic[T],))
         self.assertEqual(get_orig_bases(D), (C[int],))
-        self.assertEqual(get_orig_bases(int), None)
+        self.assertIsNone(get_orig_bases(int))
         self.assertEqual(get_orig_bases(E), (C[str], float))
 
 

diff --git a/Lib/typing.py b/Lib/typing.py
@@ -2482,7 +2482,8 @@ class Foo(Generic[T]): ...
 
     Warning
     -------
-    This will always None in the __init__/__new__ methods of the class.
+    This will always return None in the inside of the class initalisation 
+    process.
     """
     try:
         return tp.__orig_class__