ext/spl: Use zend_hash_index_add_new() for missing array keys#21535
Open
arshidkv12 wants to merge 3 commits intophp:masterfrom
Open
ext/spl: Use zend_hash_index_add_new() for missing array keys#21535arshidkv12 wants to merge 3 commits intophp:masterfrom
arshidkv12 wants to merge 3 commits intophp:masterfrom
Conversation
Girgias
reviewed
Mar 26, 2026
ext/spl/spl_array.c
Outdated
Member
There was a problem hiding this comment.
If you are going to provide such refactorings it would be nice that you found all applicable cases and submit them in one PR.
iluuu1994
reviewed
Mar 26, 2026
Member
iluuu1994
left a comment
There was a problem hiding this comment.
See this reproducer, which will segfault.
set_error_handler(function () {
global $ao;
$ao[0]++;
});
$ao = new ArrayObject();
$ao[0]++;
var_dump($ao);| retval = &EG(uninitialized_zval); | ||
| break; | ||
| case BP_VAR_RW: | ||
| zend_error(E_WARNING, "Undefined array key " ZEND_LONG_FMT, key.h); |
Member
There was a problem hiding this comment.
Technically, not sound because of this warning...
| retval = &EG(uninitialized_zval); | ||
| break; | ||
| case BP_VAR_RW: | ||
| zend_error(E_WARNING,"Undefined array key \"%s\"", ZSTR_VAL(key.key)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
zend_hash_index_update()was used, which handles both insertion and overwriting.Since we already check that the key does not exist,
zend_hash_index_add_new()is more appropriate.