Merged
Conversation
Contributor
|
@larreblarsson Did you intentionally not publish the source code at https://github.com/larreblarsson/NppStripIpAndHost ? |
Contributor
Author
|
Hi,
So you want me to change:
"-compatible-versions": "[8.3,]",
To:
"npp-compatible-versions": "[8.3,]",
For plugin AnalysePlugin, or?
/Tomas
P.S. Now this noting I have edited of course
Den tis 3 mars 2026 kl 00:39 skrev chcg ***@***.***>:
… ***@***.**** commented on this pull request.
------------------------------
In src/pl.x64.json
<#1046 (comment)>
:
> @@ -27,7 +27,7 @@
"folder-name": "AnalysePlugin",
"display-name": "AnalysePlugin",
"version": "1.13.49.0",
- "npp-compatible-versions": "[8.3,]",
+ "-compatible-versions": "[8.3,]",
Please correct that unrelated change.
—
Reply to this email directly, view it on GitHub
<#1046 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BUEAHHKWV2J2LSXND6Q7LY34OYLSBAVCNFSM6AAAAACWEJKSSWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQNZZGM4DENJWGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
Author
|
Hi,
So you want me to change:
"-compatible-versions": "[7.8,]",
To:
"npp-compatible-versions": "[7.8,]",
For plugin AndroidLogger, or?
/Tomas
P.S. Now this noting I have edited of course
Den tis 3 mars 2026 kl 00:39 skrev chcg ***@***.***>:
… ***@***.**** commented on this pull request.
------------------------------
In src/pl.x64.json
<#1046 (comment)>
:
> @@ -39,7 +39,7 @@
"folder-name": "AndroidLogger",
"display-name": "AndroidLogger",
"version": "1.4.3.4",
- "npp-compatible-versions": "[7.8,]",
+ "-compatible-versions": "[7.8,]",
Please correct that unrelated change.
—
Reply to this email directly, view it on GitHub
<#1046 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BUEAHHMJQE5X3EL5HLQLZWT4OYLSZAVCNFSM6AAAAACWEJKSSWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQNZZGM4DGMRZGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
Author
|
Hi,
It is published as an release at:
https://github.com/larreblarsson/NppStripIpAndHost/releases/download/v.1.0.0/NppStripIpAndHost.zip
I created the github repo using Visual Studio which set the x64 library to
be ignored in the .gitignore. The same folder then includes the source code.
Anyway corrected now and the source code .dll one find under my x64 folder
in my github repo
Den tis 3 mars 2026 kl 00:44 skrev chcg ***@***.***>:
… *chcg* left a comment (notepad-plus-plus/nppPluginList#1046)
<#1046 (comment)>
@larreblarsson <https://github.com/larreblarsson> Did you intentionally
not publish the source code at
https://github.com/larreblarsson/NppStripIpAndHost ?
—
Reply to this email directly, view it on GitHub
<#1046 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BUEAHHKFTIWMA6BLHNYFIRD4OYMGVAVCNFSM6AAAAACWEJKSSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSOBXGY4DCMZTHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
|
@larreblarsson It didn't meant that you add the binary data like https://github.com/larreblarsson/NppStripIpAndHost/tree/master/x64/Debug but I meant the header and sourcefiles .h and .cpp, so e.g. which is probably on level above the github repo. Compared to https://github.com/npp-plugins/plugintemplate you moved the Visual Studio project file to the top level and therefore the src folder is not part of your github repo. |
Contributor
Author
|
Ah! Sorry! Once again it was because I let MS VS automatically create my
Github repo (will not happen again I can say) where it for some reason
choosed to create it at my vs.proj folder level. Anyways I moved it up one
level so now also includes my src folder.
Den ons 4 mars 2026 kl 23:31 skrev chcg ***@***.***>:
… *chcg* left a comment (notepad-plus-plus/nppPluginList#1046)
<#1046 (comment)>
@larreblarsson <https://github.com/larreblarsson> It didn't meant that
you add the binary data like
https://github.com/larreblarsson/NppStripIpAndHost/tree/master/x64/Debug
but I meant the header and sourcefiles .h and .cpp, so e.g.
which is probably on level above the github repo. Compared to
https://github.com/npp-plugins/plugintemplate you moved the Visual Studio
project file to the top level and therefore the src folder is not part of
your github repo.
—
Reply to this email directly, view it on GitHub
<#1046 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BUEAHHPL472IPWE3KNEVMBT4PCVEVAVCNFSM6AAAAACWEJKSSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSOJZGQ3TMNJWG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
|
Some corrections towards a usable plugin see larreblarsson/NppStripIpAndHost#1 . Especially fileinfo version in NppPluginDemo.rc needs to match to the version here. Furthermore hash: NppStripIpAndHost |
chcg
reviewed
Mar 15, 2026
chcg
reviewed
Mar 15, 2026
Contributor
|
@larreblarsson What about providing also win32 and arm64 versions of your plugin? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.