Skip to content

Add template code for missing Lexers (issue #1258)#2469

Closed
Cyrillev91 wants to merge 1 commit intonotepad-plus-plus:masterfrom
Cyrillev91:master
Closed

Add template code for missing Lexers (issue #1258)#2469
Cyrillev91 wants to merge 1 commit intonotepad-plus-plus:masterfrom
Cyrillev91:master

Conversation

@Cyrillev91
Copy link
Contributor

@Cyrillev91 Cyrillev91 commented Oct 23, 2016

See my coment in Issue #1258

@Cyrillev91 Cyrillev91 mentioned this pull request Oct 23, 2016
77 tasks
Copy link
Contributor

@MAPJe71 MAPJe71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read and apply Guidelines for pull requests.

const int LANG_INDEX_TYPE5 = 6;
const int LANG_INDEX_TYPE6 = 7;
const int LANG_INDEX_TYPE7 = 8;
const int LANG_INDEX_TYPE8 = 9; /* Sintillia : keyword list 0 to 8 (KEYWORDSET_MAX = 8)*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Scintilla

const char * keyWords_char = wmc->wchar2char(pKwArray[LANG_INDEX_TYPE7], CP_ACP);
setKeywords(langType, keyWords_char, LANG_INDEX_TYPE7);
}
//Sintillia : keyword list 0 to 8 (KEYWORDSET_MAX = 8)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Scintilla

@Croydon
Copy link
Contributor

Croydon commented Oct 23, 2016

Thanks!

@Cyrillev91
Copy link
Contributor Author

@MAPJe71 PR updated (Scintilla)

@donho donho added the reject label Oct 24, 2016
@donho
Copy link
Member

donho commented Oct 24, 2016

No empty template. Please add only lexers you need.

@donho donho closed this Oct 24, 2016
@Cyrillev91
Copy link
Contributor Author

Hi @donho and all,
Ok, I would suggest again a PR when I should add multiple Lexer.

But as Mr. @dail8859 says in issue #1258 "Unfortunately adding a new lexer is a bit tedious, and every time a new lexer is added all other PRs for lexers need fixed because there will be merge conficts :("
"Usually about 10 files need modified. For example if you take a look here you can see this pending PR for adding Visual Prolog."

This PR was to simplify adding lexer and "connect" lexer already in Scintilla.

Until I create a new PR, can you add the following PR ? :

chcg added a commit to chcg/notepad-plus-plus that referenced this pull request Apr 3, 2025
Release 5.5.6 (https://www.scintilla.org/scintilla556.zip)

    Released 2 April 2025.
    Disallow changing case of protected text. Bug notepad-plus-plus#2463.
    Return enumeration type from MarkerSymbolDefined to match MarkerDefine. Bug notepad-plus-plus#2469.
    On Win32, use DirectWrite for autocompletion lists when DirectWrite chosen for document text.
    On Win32, optimize case-insensitive DBCS search to be around 5 times faster by using 64K memory to cache folding data for each DBCS code page used.
    On Win32, fix a crash with bidirectional text.
    When using Visual C++ through nmake, fix building for ARM64. Feature notepad-plus-plus#1546.
    On Qt, draw clipped UTF-8 text correctly. Bug notepad-plus-plus#2464.
    On Qt, avoid a dwell start when the mouse is moved outside the Scintilla widget. Bug notepad-plus-plus#2466.
    On Qt, autoCompleteSelection converts from local encoding when not in Unicode mode. Bug notepad-plus-plus#2465.

Release 5.4.4 (https://www.scintilla.org/lexilla544.zip)

    Released 2 April 2025.
    Fix building for ARM64. Pull request notepad-plus-plus#308.
donho pushed a commit that referenced this pull request Apr 8, 2025
Release 5.5.6 (https://www.scintilla.org/scintilla556.zip)

    Released 2 April 2025.
*   Disallow changing case of protected text. Bug #2463.
*   Return enumeration type from MarkerSymbolDefined to match MarkerDefine. Bug #2469.
*   On Win32, use DirectWrite for autocompletion lists when DirectWrite chosen for document text.
*   On Win32, optimize case-insensitive DBCS search to be around 5 times faster by using 64K memory to cache folding data for each DBCS code page used.
*   On Win32, fix a crash with bidirectional text.
*   When using Visual C++ through nmake, fix building for ARM64. Feature #1546.
*   On Qt, draw clipped UTF-8 text correctly. Bug #2464.
*   On Qt, avoid a dwell start when the mouse is moved outside the Scintilla widget. Bug #2466.
*   On Qt, autoCompleteSelection converts from local encoding when not in Unicode mode. Bug #2465.

Release 5.4.4 (https://www.scintilla.org/lexilla544.zip)

    Released 2 April 2025.
*   Fix building for ARM64. Pull request #308.

Close #16373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants