Skip to content

Update to scintilla 5.5.7 & Lexilla 5.4.5#16649

Closed
chcg wants to merge 1 commit intonotepad-plus-plus:masterfrom
chcg:scintilla_557
Closed

Update to scintilla 5.5.7 & Lexilla 5.4.5#16649
chcg wants to merge 1 commit intonotepad-plus-plus:masterfrom
chcg:scintilla_557

Conversation

@chcg
Copy link
Contributor

@chcg chcg commented Jun 9, 2025

Release 5.5.7 (https://www.scintilla.org/scintilla557.zip)

Released 8 June 2025.
Add SCI_SCROLLVERTICAL method to restore view position and maintain it while performing line wrapping.
Add SC_UNDO_SELECTION_HISTORY_SCROLL flag to SCI_SETUNDOSELECTIONHISTORY which controls whether undo and redo restore vertical scroll position.
Tweak SC_MARK_BAR to be slightly wider by using next higher whole pixel instead of next lower for margin width / 3.
Scale images in autocompletion lists with SCI_AUTOCSETIMAGESCALE to match high DPI screens. Initially only on GTK and Qt.
Fix wrapping bug for UTF-8 where \r\n could wrap between the characters. Notepad++ Pull Request #16373.
Fix crash during painting when scroll bars changed. Bug #2481.
On GTK, reset vertical scroll bar synchronously in SCI_SETDOCPOINTER to fix bug where scroll position not restored in non-wrap mode. Bug #2416.
On GTK, fix IME problem when tentative composition interfered with delete surrounding. Feature #1476.
On GTK, update IME cursor position inside retrieve surrounding to better position candidate window. Feature #1488.

Release 5.4.5 (https://www.scintilla.org/lexilla545.zip)

Released 8 June 2025.
Dart: Add error state SCE_DART_STRINGEOL for unterminated string. Pull request #315.
Makefile: Add a keyword list to makefile lexer to highlight GNU Make directives like 'ifdef' and 'vpath' as SCE_MAKE_PREPROCESSOR since these are similar to NMAKE directives like '!IFDEF'.
Nix: Add error state SCE_NIX_STRINGEOL for unterminated string. Pull request #315.
TOML: Add error state SCE_TOML_STRINGEOL for unterminated string. Pull request #315.
Zig: Add error state SCE_ZIG_STRINGEOL for unterminated string. Pull request #315.

@chcg
Update to scintilla 5.5.7 & Lexilla 5.4.5
f52f1d8 
Release 5.5.7 (https://www.scintilla.org/scintilla557.zip)

    Released 8 June 2025.
    Add SCI_SCROLLVERTICAL method to restore view position and maintain it while performing line wrapping.
    Add SC_UNDO_SELECTION_HISTORY_SCROLL flag to SCI_SETUNDOSELECTIONHISTORY which controls whether undo and redo restore vertical scroll position.
    Tweak SC_MARK_BAR to be slightly wider by using next higher whole pixel instead of next lower for margin width / 3.
    Scale images in autocompletion lists with SCI_AUTOCSETIMAGESCALE to match high DPI screens. Initially only on GTK and Qt.
    Fix wrapping bug for UTF-8 where \r\n could wrap between the characters. Notepad++ Pull Request notepad-plus-plus#16373.
    Fix crash during painting when scroll bars changed. Bug notepad-plus-plus#2481.
    On GTK, reset vertical scroll bar synchronously in SCI_SETDOCPOINTER to fix bug where scroll position not restored in non-wrap mode. Bug notepad-plus-plus#2416.
    On GTK, fix IME problem when tentative composition interfered with delete surrounding. Feature notepad-plus-plus#1476.
    On GTK, update IME cursor position inside retrieve surrounding to better position candidate window. Feature notepad-plus-plus#1488.

Release 5.4.5 (https://www.scintilla.org/lexilla545.zip)

    Released 8 June 2025.
    Dart: Add error state SCE_DART_STRINGEOL for unterminated string. Pull request notepad-plus-plus#315.
    Makefile: Add a keyword list to makefile lexer to highlight GNU Make directives like 'ifdef' and 'vpath' as SCE_MAKE_PREPROCESSOR since these are similar to NMAKE directives like '!IFDEF'.
    Nix: Add error state SCE_NIX_STRINGEOL for unterminated string. Pull request notepad-plus-plus#315.
    TOML: Add error state SCE_TOML_STRINGEOL for unterminated string. Pull request notepad-plus-plus#315.
    Zig: Add error state SCE_ZIG_STRINGEOL for unterminated string. Pull request notepad-plus-plus#315.
@chcg
Copy link
Contributor Author

chcg commented Jun 9, 2025

Fix for regression with scintilla 5.5.6, see #16373

@chcg chcg added scintilla dependent Can't be considered for N++ implementation unless/until Scintilla changes lexilla dependent Can't be considered for N++ implementation unless/until Lexiilla changes labels Jun 9, 2025
@donho donho self-assigned this Jun 10, 2025
donho
donho reviewed Jun 13, 2025
View reviewed changes
scintilla/win32/PlatWin.cxx

HMONITOR hMonitor = MonitorFromRect(&rcMonitor, MONITOR_DEFAULTTONEAREST);
// If hMonitor is NULL, that's just the main screen anyway.
// If hMonitor is NULL, that's just the main screen anyways.
Copy link
Member

@donho donho Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a remark:
Comparing the difference in v5.5.6, it seems we have "fixed" the typo in the comment (though I didn't see it).
It's good to keep the typo as it is, so next update, we don't check this file.

Copy link
Contributor Author

@chcg chcg Jun 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo change came from b742c54#diff-90a720dd83a501deb7a8329865ebdefae5156329cc211762ffe9f825dcfa5579 .

@donho donho added the accepted label Jun 13, 2025
@donho donho closed this in e85c354 Jun 13, 2025
@chcg chcg deleted the scintilla_557 branch June 15, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@donho donho donho left review comments

Assignees

@donho donho

Labels

accepted lexilla dependent Can't be considered for N++ implementation unless/until Lexiilla changes scintilla dependent Can't be considered for N++ implementation unless/until Scintilla changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chcg @donho