Skip to content

Avoid usage of non FULL scintilla interfaces#16522

Closed
chcg wants to merge 1 commit intonotepad-plus-plus:masterfrom
chcg:deprecate_32bit_sci_structs_and_defines
Closed

Avoid usage of non FULL scintilla interfaces#16522
chcg wants to merge 1 commit intonotepad-plus-plus:masterfrom
chcg:deprecate_32bit_sci_structs_and_defines

Conversation

@chcg
Copy link
Contributor

@chcg chcg commented May 7, 2025 •
edited
Loading

  • see discussion at Fix: Block Uncomment functionality removes comment tags even with quotes #16467
  • disabled versions with usage of Sci_PositionCR restricted to 2GB files on windows to avoid usage within N++ and to enforce usage of new functions within plugins
  • didn't adapt ScintillaStructures.h to avoid disabling/patching of functions for SCI_GETTEXTRANGE, SCI_FINDTEXT, SCI_GETSTYLEDTEXTFULL and SCI_FORMATRANGE within scintilla code

@chcg
- disabled versions with usage of Sci_PositionCR restricted to 2GB fi…
9cac77c 
…les on windows

- didn't adapt ScintillaStructures.h yet to avoid disabling/patching of functions for SCI_GETTEXTRANGE, SCI_FINDTEXT, SCI_GETSTYLEDTEXTFULL and SCI_FORMATRANGE already now
@chcg chcg mentioned this pull request May 7, 2025
Open
@donho donho self-assigned this May 7, 2025
@donho donho added the accepted label May 7, 2025
@donho donho closed this in 34677a5 May 7, 2025
@pryrt pryrt mentioned this pull request May 7, 2025
Merged
@chcg chcg deleted the deprecate_32bit_sci_structs_and_defines branch May 12, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@donho donho

Labels

accepted build / code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chcg @donho