Skip to content

adding FlushFileBuffers-fail user notification#14842

Closed
xomx wants to merge 2 commits intonotepad-plus-plus:masterfrom
xomx:FlushFileBuffers-fail-notification
Closed

adding FlushFileBuffers-fail user notification#14842
xomx wants to merge 2 commits intonotepad-plus-plus:masterfrom
xomx:FlushFileBuffers-fail-notification

Conversation

@xomx
Copy link
Contributor

@xomx xomx commented Mar 8, 2024

Helps in fixing the #6133 .

With this PR the affected users will be at least alerted that something bad is happening.

Simulated case message:
npp-ffb-fail-notification-smaller

@xomx
Copy link
Contributor Author

xomx commented Mar 8, 2024

@donho
During testing, I discovered the possibility that under certain conditions the N++ can crash (and thus possibly cause some disk corruptions - but this I have not proven yet) when using snapshot backups. It is all about the ability to recursively (ab)use the N++ backup-mutex. I will investigate and let you know.

@donho donho self-assigned this Mar 8, 2024
Copy link
Member

@donho donho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider to merge the 2 treatments into one block.

@donho donho added enhancement Proposed enhancements of existing features accepted labels Mar 9, 2024
@donho donho closed this in 4e1a3ee Mar 9, 2024
@xomx xomx deleted the FlushFileBuffers-fail-notification branch March 11, 2024 09:19
@xomx xomx mentioned this pull request Sep 29, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted enhancement Proposed enhancements of existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants