Skip to content

Installer: Correctly delete tabContextMenu_example.xml in the users profile#13654

Closed
sredna wants to merge 1 commit intonotepad-plus-plus:masterfrom
sredna:inst_202305_deluserexamplexml
Closed

Installer: Correctly delete tabContextMenu_example.xml in the users profile#13654
sredna wants to merge 1 commit intonotepad-plus-plus:masterfrom
sredna:inst_202305_deluserexamplexml

Conversation

@sredna
Copy link
Contributor

@sredna sredna commented May 13, 2023

tabContextMenu_example.xml must be deleted in the correct shell context so that $APPDATA resolves to the users profile.

Fix #13670

@chcg chcg added the installer label May 14, 2023
@donho
Copy link
Member

donho commented May 18, 2023

@sredna
All Pull Requests, except for translations and user documentation, need to be attached to a issue on GitHub.
https://github.com/notepad-plus-plus/notepad-plus-plus/blob/master/CONTRIBUTING.md#pull-requests

So please create an issue and ping me. I'll reopen this PR then.

@donho donho closed this May 18, 2023
@donho donho added the reject label May 18, 2023
@donho donho reopened this May 19, 2023
@donho donho self-assigned this May 19, 2023
@donho donho added accepted and removed reject labels May 19, 2023
@donho donho closed this in 8250a81 May 19, 2023
molsonkiko pushed a commit to molsonkiko/notepad-plus-plus that referenced this pull request Jun 13, 2023
Correctly delete tabContextMenu_example.xml in the users profile.

Fix notepad-plus-plus#13670, close notepad-plus-plus#13654
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uninstaller fails to delete tabContextMenu_example.xml in the users profile

3 participants