Update pascal.xml to fix issue with Pascal units#12686
Closed
Zaaphod wants to merge 1 commit intonotepad-plus-plus:masterfrom
Closed
Update pascal.xml to fix issue with Pascal units#12686Zaaphod wants to merge 1 commit intonotepad-plus-plus:masterfrom
Zaaphod wants to merge 1 commit intonotepad-plus-plus:masterfrom
Conversation
|
@Zaaphod I think you need to link an issue. I've created one for you. Add the text "fix #12687, updates #12489" to your commit message please. Thank you for the contribution! Cheers. |
fix notepad-plus-plus#12687, updates notepad-plus-plus#12489 Pascal Units require a definition of each function and procedure as a header of the unit. This causes the function list to have duplicates of each function and procedure in the definition. To solve this duplication and make the list only take you to the actual functions, I've added another comment definition that uses the keywords Interface which must always be before the function definitions and implementation which always must be after the definitions and before the actual functions. so everything between Interface and Implementation is ignored the way it should be. If someone wants the duplicates for some strange reason, they can always comment that line out.
cf829eb to
a5c885f
Compare
Author
|
@vinsworldcom Thank your help. I think I updated the commit message. |
This was referenced Dec 23, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pascal Units require a definition of each function and procedure as a header of the unit. This causes the function list to have duplicates of each function and procedure in the definition. To solve this duplication and make the list only take you to the actual functions, I've added another comment definition that uses the keywords Interface which must always be before the function definitions and implementation which always must be after the definitions and before the actual functions. so everything between Interface and Implementation is ignored the way it should be. If someone wants the duplicates for some strange reason, they can always comment that line out.