Skip to content

Make Notepad++ color customizable#10128

Closed
donho wants to merge 4 commits intonotepad-plus-plus:masterfrom
donho:change_dark_mode_color
Closed

Make Notepad++ color customizable#10128
donho wants to merge 4 commits intonotepad-plus-plus:masterfrom
donho:change_dark_mode_color

Conversation

@donho
Copy link
Member

@donho donho commented Jul 9, 2021

Notepad++ is dark-modable now, but why not in green/purple/yellow/red/blue/etc... mode?
This PR is try to make Notepad++ color customizable.
image

@donho
Copy link
Member Author

donho commented Jul 9, 2021

@ozone10
I made all members in darkColors structure more blue to see the result:

image

As you can see in the screenshot, there are at least 3 places remain unchanged, and it seems the 3 API are the undocumented ones, controlled by WDM. Do you know how to change the colors?

@ozone10
Copy link
Contributor

ozone10 commented Jul 9, 2021

Unfortunately, unless we owner draw it, it is not possible. And for title bar I don't think it's possible.
for scrollbar: https://docs.microsoft.com/en-us/windows/win32/controls/wm-ctlcolorscrollbar

@donho
Copy link
Member Author

donho commented Jul 9, 2021

@ozone10
Then these colors won't be changed and I will make only dark mode but with the different colors for choice.
Thank you for your reply.

@donho donho marked this pull request as draft July 9, 2021 12:56
@mere-human
Copy link
Contributor

This PR is try to make Notepad++ color customizable.

This looks nice even though other areas aren't customizable!

@donho donho marked this pull request as ready for review July 10, 2021 01:41
@donho donho force-pushed the change_dark_mode_color branch from 1de9048 to fd0539a Compare July 10, 2021 01:42
@donho
Copy link
Member Author

donho commented Jul 10, 2021

@mere-human
More color tones supported. Check it out ;)

@donho donho closed this in 39b9090 Jul 10, 2021
@donho donho deleted the change_dark_mode_color branch July 10, 2021 12:21
@mere-human
Copy link
Contributor

@donho

@mere-human
More color tones supported. Check it out ;)

I checked it out. Looks good!
image

However, for some reason, when I switched from default Black (Dark mode) to e.g. Red tone, the editor style became default white as you can see above.

@mere-human
Copy link
Contributor

Also, how about to show small color swatches near each tone here?
image
For example, like here in the Style Configurator:
image

@GOLEM777
Copy link
Contributor

Also, how about to show add color picker for custom customizing self color?

@chcg chcg added the dark mode Dark mode related issues, fixes label Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dark mode Dark mode related issues, fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants