TST: Restore some tolerances for some arch/platform-specific failures#31343
TST: Restore some tolerances for some arch/platform-specific failures#31343QuLogic wants to merge 3 commits intomatplotlib:text-overhaulfrom
Conversation
9f6c9e9 to
8a451fb
Compare
34a33c2 to
4e264da
Compare
|
OK, this is now passing. The failure in |
|
OK, it does require a bit of internal trickery, but instead of the last commit, we can instead do #31371. |
When outputting files using the "core 14 fonts" (e.g., `rcParams['pdf.use14corefonts'] = True`), text will be measured using our internal AFM files instead of any external files. While we don't have a full API decided for how to pass full `Text` objects through backends, add in a small internal helper to allow the PS/PDF backends to override font height metrics with the AFM files.
|
Rebased on top of #31371 and dropped the AFM test change since that PR's approved. |
|
Test failures are a bit getting out of hand, so that I don't dare to merge. We should fix setuptools scm, likely temporarily by pinning <10.0, see #31387. |
|
OK, I've pinned setuptools-scm for this branch and I think I've got all the places. Unfortunately, since this branch hasn't been merged with |
|
OK, looks like I didn't increase one tolerance enough, and |
The tolerance on these was increased in various PRs, with notes to reduce/remove them, so they were removed in matplotlib#30184, but should have been reverted to a smaller value. - `test_floating_axes.py::test_curvelinear4[png]` fails on macOS - `test_grid_helper_curvelinear.py::test_axis_direction[png]` fails on ARM and macOS - `test_grid_helper_curvelinear.py::test_polar_box[png]` fails on Windows, ARM, and macOS These fail on macOS; there's a tolerance on them already, they fail by just a small amount, so increase it. - `test_bbox_tight.py::test_bbox_inches_tight_suptile_legend[png]` - `test_patheffects.py::test_collection[png]` - `test_axes3d.py::test_scale3d_artists_log[png]`
This is currently causing warnings at runtime in the editable install, which breaks almost all tests.
So before the AFM change, the minimum ascent was 15.1953125, and after it's 15.195312499999996 which causes only the A in the legend to shift slightly. I don't think that's too important, so I've just updated the final figure in the other branch and restarted the CI here. |
PR summary
test_polar_boxfails on Windows, ARM, and macOS.test_axis_directionfails on ARM and macOS.There are still a few more to fix, but just checking that these are fine.
AI Disclosure
None
PR checklist