Open
Conversation
rcosta358
commented
Mar 17, 2026
| } | ||
|
|
||
| private static boolean containsConjunct(Predicate c1, Predicate c2) { | ||
| if (c1.toString().equals(c2.toString())) |
Collaborator
Author
There was a problem hiding this comment.
Used string comparison instead of equals() to handle inconsistent GroupExpression wrapping.
Collaborator
There was a problem hiding this comment.
lets juts add this to the javadoc so we know in the future
rcosta358
commented
Mar 17, 2026
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object obj) { |
Collaborator
Author
There was a problem hiding this comment.
Added missing equals() for predicates anyway.
CatarinaGamboa
approved these changes
Mar 27, 2026
| } | ||
|
|
||
| private static boolean containsConjunct(Predicate c1, Predicate c2) { | ||
| if (c1.toString().equals(c2.toString())) |
Collaborator
There was a problem hiding this comment.
lets juts add this to the javadoc so we know in the future
| // check if c2 is already present in the conjunctions of c1 | ||
| if (containsConjunct(c1, c2)) | ||
| return c1; | ||
|
|
Collaborator
There was a problem hiding this comment.
there might be a case where c2 contains c1 so lets add that case. Also javadoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a small simplification to avoid duplicate conjunctions in predicates, which made error messages redundant and harder to read.
To fix this, before creating a conjunction with two predicates, it recursively checks whether the second operand is already present in the first operand conjunctions. If so, the first one is returned.
Example
Before
After
After with #181