[13.x] Serve exception pages as Markdown via Accept header#59371
Open
WendellAdriel wants to merge 1 commit into13.xfrom
Open
[13.x] Serve exception pages as Markdown via Accept header#59371WendellAdriel wants to merge 1 commit into13.xfrom
WendellAdriel wants to merge 1 commit into13.xfrom
Conversation
When a client sends `Accept: text/markdown`, the exception handler now returns the same rich markdown payload used by the error page copy button. Precedence follows the existing pattern: JSON > Markdown > HTML. Debug-off and custom ExceptionRenderer scenarios fall back to a minimal `# Server Error` document to avoid leaking internals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept: text/markdown, the exception handler returns the same rich markdown payload used by the error page's copy button (text/markdown; charset=UTF-8)shouldReturnMarkdown()/shouldRenderMarkdownWhen()API that mirrors the JSON equivalentExceptionRendererscenarios fall back to a minimal# Server Errordocument to avoid leaking internalsChanges
Renderer: ExtractedresolveException()and addedrenderMarkdown()so HTML and markdown responses share one code pathHandler: AddedshouldReturnMarkdown,shouldRenderMarkdownWhen,prepareMarkdownResponse,renderExceptionAsMarkdown; updatedrenderExceptionResponseto branch markdown after JSONRendererTest: 7 new integration tests covering happy path, charset parameter, all precedence combos, debug-off, and custom renderer fallbackTest plan
Accept: text/markdownreturns 500 with markdown content type and rich stack tracetext/markdown; charset=utf-8works identicallyAccept: application/json, text/markdownreturns JSONAccept: text/markdown, application/jsonreturns markdownAccept: text/html, text/markdownreturns HTML