Skip to content

__ne__ of dict return NotImplemented #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ncw merged 2 commits into from
Oct 8, 2019
Merged

__ne__ of dict return NotImplemented #109

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b364b3
__ne__ of dict return NotImplemented
HyeockJinKim Sep 30, 2019
fb48d32
Add tests for dict.__ne__ and dict.__eq__
HyeockJinKim Sep 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
__ne__ of dict return NotImplemented 
if type of other is not dict,
return NotImplemented

Fixes #108
  • Loading branch information
@HyeockJinKim
HyeockJinKim committed Sep 30, 2019
commit 9b364b3fe82ec1e3caa5e6cf6a7aea967f135598
3 changes: 3 additions & 0 deletions py/dict.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,9 @@ func (a StringDict) M__ne__(other Object) (Object, error) {
if err != nil {
return nil, err
}
if res == NotImplemented {
return res, nil
}
if res == True {
return False, nil
}
Expand Down