fix: variables with same name but different scope should be deletable#962
Merged
TimKnight-DWP merged 36 commits intogitlabform:v5from Sep 17, 2025
Merged
fix: variables with same name but different scope should be deletable#962TimKnight-DWP merged 36 commits intogitlabform:v5from
TimKnight-DWP merged 36 commits intogitlabform:v5from
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v5 #962 +/- ##
==========================================
+ Coverage 83.28% 88.37% +5.09%
==========================================
Files 73 73
Lines 3565 3640 +75
==========================================
+ Hits 2969 3217 +248
+ Misses 596 423 -173
🚀 New features to boost your workflow:
|
…d to use python-gitlab
…p duration" This reverts commit a5f0e86.
This reverts commit 573e997.
This reverts commit b83a286.
This reverts commit 3a99730.
Changed test structure to follow rest of the repo convention and it also makes it easy to follow the test cases. Caught a couple of bugs that have been fixed as well.
…ture for performance reason
3f2b7eb to
333ec09
Compare
TimKnight-DWP
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug reported in #533. I think this is an important bug that unfortunately hadn't been fixed yet.
As per the referenced issue, if there are multiple CI CD variables with same key/name but scoped to different "environment", gitlabform does not make the API call correctly. As a result, the variable cannot be deleted and an error is returned.
There's a lot of changes in this PR, but here's an overview of the changes for better understanding:
MultipleEntitiesProcessor), which can unintentionally affect other processors and introduce other bugs in case of lack of tests.fixes: #533