On branch edburns/dd-2855288-add-smoke-test-to-build-and-test Use a non-agentic workflow. More deterministic.#25
Merged
edburns merged 3 commits intogithub:mainfrom Mar 25, 2026
Conversation
…on-agentic workflow. More deterministic. Your branch is ahead of 'origin/edburns/dd-2855288-add-smoke-test-to-build-and-test' by 1 commit. deleted: .github/workflows/run-smoke-test.lock.yml deleted: .github/workflows/run-smoke-test.md new file: .github/workflows/run-smoke-test.yml Signed-off-by: Ed Burns <edburns@microsoft.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces the previous agentic-workflow (markdown + generated lock workflow) with a single, non-agentic GitHub Actions workflow that builds the SDK locally, has Copilot CLI generate the smoke-test Maven project from src/test/prompts/PROMPT-smoke-test.md, and then runs the resulting smoke-test JAR.
Changes:
- Add a new
run-smoke-test.ymlworkflow to build/install the SDK, generate the smoke-test project via Copilot CLI, and run the smoke-test JAR. - Remove the previous agentic workflow source (
run-smoke-test.md) and its compiled lock workflow (run-smoke-test.lock.yml).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/run-smoke-test.yml | New non-agentic workflow to build the SDK, generate the smoke test project, and run the jar deterministically. |
| .github/workflows/run-smoke-test.md | Removed agentic workflow prompt/instructions file. |
| .github/workflows/run-smoke-test.lock.yml | Removed generated agentic lock workflow. |
This is an absolutely excellent suggestion. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
modified: .github/workflows/run-smoke-test.yml modified: pom.xml @Copilot wrote: > mvn -DskipTests clean install will still execute generate-test-resources, which in this repo runs a git clone of github/copilot-sdk and an npm install (see pom.xml plugin executions bound to generate-test-resources). This adds extra network + npm variability to what is otherwise just an SDK install step. Consider adding a dedicated Maven profile/flag to skip those test-harness setup executions for this workflow, so the smoke test depends only on building/installing the SDK artifact. This is an excellent suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your branch is ahead of 'origin/edburns/dd-2855288-add-smoke-test-to-build-and-test' by 1 commit.
deleted: .github/workflows/run-smoke-test.lock.yml
deleted: .github/workflows/run-smoke-test.md
new file: .github/workflows/run-smoke-test.yml