github: try to make token generation more robust against bad connection#1045
github: try to make token generation more robust against bad connection#1045MichaelMure wants to merge 1 commit intotrunkfrom
Conversation
|
Sometimes it fails even earlier: Will play more with the bridge creation trying to catch most failure modes. |
There was a problem hiding this comment.
Should we adopt something like backoff? (https://pkg.go.dev/github.com/cenkalti/backoff/v4). This is probably not the only place that would benefit from retries. We should also output a warning if the users GITHUB_TOKEN isn't valid (has expired, etc) since you technically have a token but you're still rate-limited like an unauthorized user.
|
This bot triages pull requests in order to help the maintainers
This bot will not automatically close stale pull requests. To remove the stale status, you can:
To avoid automatic lifecycle management of this pull request, add |
yes :) |
No description provided.