ref(core): Introduce instrumented method registry for AI integrations#19981
Open
nicohrubec wants to merge 15 commits intodevelopfrom
Open
ref(core): Introduce instrumented method registry for AI integrations#19981nicohrubec wants to merge 15 commits intodevelopfrom
nicohrubec wants to merge 15 commits intodevelopfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧Core
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
chargome
approved these changes
Mar 26, 2026
Member
chargome
left a comment
There was a problem hiding this comment.
LGTM, pls do a double-check if the types that got deleted were exported, bc then this would be breaking technically. Would mention this in the changelog if that's the case
| 'models.generateContentStream': { operation: 'generate_content', streaming: true }, | ||
| 'chats.create': { operation: 'chat' }, | ||
| // chat.* paths are built by createDeepProxy when it proxies the chat instance with CHAT_PATH as base | ||
| 'chat.sendMessage': { operation: 'chat' }, |
Member
There was a problem hiding this comment.
l: we could actually use CHAT_PATH here instead of hardcoding
Member
Author
There was a problem hiding this comment.
I'll likely get rid of CHAT_PATH in a follow up, can think about introducing a more broad operations objects to handle all of these ops constants
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Member
Author
|
@chargome right they are exported (for reasons idk because they are not used anywhere it seems). I put them back in with a deprecation notice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the shared
getOperationName()function with per-provider method registries that map API paths to their operation name and streaming behavior. This explicitly couples the instrumented methods and necessary metadata in one place instead of having convoluted substring matching in multiple places that can be quite hard to reason about.Closes #19987 (added automatically)