Skip to content

refactor: remove dead named-window lookup from guest-window-manager#50496

Open
trop[bot] wants to merge 1 commit into42-x-yfrom
trop/42-x-y-bp-refactor-remove-dead-named-window-lookup-from-guest-window-manager-1774460935395
Open

refactor: remove dead named-window lookup from guest-window-manager#50496
trop[bot] wants to merge 1 commit into42-x-yfrom
trop/42-x-y-bp-refactor-remove-dead-named-window-lookup-from-guest-window-manager-1774460935395

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Mar 25, 2026

Backport of #50474

See that PR for details.

Notes: none

The frameNamesToWindow map was a holdover from the BrowserWindowProxy
IPC shim. Since nativeWindowOpen became the only code path, Blink's
FrameTree::FindOrCreateFrameForNavigation resolves named window targets
directly in the renderer, scoped to the opener's browsing context
group. When a matching named window exists, Blink navigates it without
ever sending a CreateNewWindow IPC to the browser, so this map was
never consulted in the legitimate same-opener case.

The only time the map found a match was when two unrelated renderers
happened to use the same target name, in which case openGuestWindow
would short-circuit before consuming the guest WebContents that
Chromium had already created for the new window, leaking it.

Adds a test verifying Blink handles same-opener named-target reuse
end-to-end without any browser-side tracking.

Co-authored-by: Sam Attard <sattard@anthropic.com>
@trop trop bot requested review from a team and MarshallOfSound March 25, 2026 17:49
@trop trop bot added 42-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

42-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant