Skip to content

[DESKTOP-1894] Add Jenkinsfile#22

Merged
StefanScherer merged 1 commit intodocker:masterfrom
StefanScherer:add-jenkinsfile
Oct 23, 2019
Merged

[DESKTOP-1894] Add Jenkinsfile#22
StefanScherer merged 1 commit intodocker:masterfrom
StefanScherer:add-jenkinsfile

Conversation

@StefanScherer
Copy link
Copy Markdown
Member

This PR adds a Jenkinsfile to build, test, package and later also publish/push the package.

@StefanScherer StefanScherer force-pushed the add-jenkinsfile branch 4 times, most recently from baa3378 to 303ac8a Compare September 25, 2019 10:51
@mikeparker
Copy link
Copy Markdown
Contributor

I don't know much about the format but it looks fine to me. I suppose a few basic questions:

  1. Whats the quiet period?
  2. Do we need to keep logs for 30 days?
  3. What does preserve stashes do
  4. Is a 1 hour timeout a little long? (it should take like 5 minutes)
  5. Do we know that the selected image supports building .net standard .net core and .net framework packages?

Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
@StefanScherer
Copy link
Copy Markdown
Member Author

Thanks @mikeparker for your review and questions.
I've changed some settings in the Jenkinsfile.

  1. removed the quiet period. This is for more heavier pipelines when a lot of commits arrive, wait for the last commit and then run a build after the quiet period.
  2. keep only the last 10 logs
  3. I've removed the preserved stashes, not needed in that pipeline.
  4. well that's a timeout, I don't want to have it too short. Spinning up the windows-2019 instance and pulling the base image will take longer than 5 minutes when there is no instance running. Once it's up and running, another build will be much faster. So, keep it at 1 hour for now.
  5. I don't know. I think we have to try it out to see if the whole pipeline works after moving to Jenkins.

@StefanScherer StefanScherer merged commit 56844a9 into docker:master Oct 23, 2019
@StefanScherer StefanScherer deleted the add-jenkinsfile branch October 23, 2019 12:01
@StefanScherer
Copy link
Copy Markdown
Member Author

The Jenkins pipeline is here: https://ci.docker.com/public/job/HttpOverStream/job/master/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants