refactor: more robust method to detect duplicate index#1651
refactor: more robust method to detect duplicate index#1651hsm207 merged 9 commits intodocarray:mainfrom
Conversation
…07/refactor-duplicate-index
ef6e251 to
c57d576
Compare
|
@JoanFM @JohannesMessner mypy and black is failing on files I did not modify and I already pulled from main |
JoanFM
left a comment
There was a problem hiding this comment.
I guess u need to commit pyproject updated and not only poetry.lock?
the pyproject.toml file already has what I want when I pulled from main i.e.:
I don't know if this is the expected behavior, but after the pull, I ran |
|
Not sure, but in that case, I would not update the |
|
Why is there a need to update the lock file ? Not sure that I follow |
This reverts commit eb3c3d2.
…07/refactor-duplicate-index
24aece2 to
fb48a40
Compare
when I pull from upstream/main, I noticed there was a change in my pyproject.toml so I ran I've updated the PR so that the lock file here matches upstream/main too. |
fixes #1357