[PECOBLR-2086] Add comprehensive MST transaction metadata and edge case tests#763
Open
vikrantpuppala wants to merge 2 commits intomainfrom
Open
[PECOBLR-2086] Add comprehensive MST transaction metadata and edge case tests#763vikrantpuppala wants to merge 2 commits intomainfrom
vikrantpuppala wants to merge 2 commits intomainfrom
Conversation
523ab8e to
85e92e1
Compare
Adds 42 new E2E tests and 3 unit tests covering gaps identified in MST + xDBC metadata audit: E2E tests (test_transactions.py): - Metadata operations (cursor.columns/tables/schemas/catalogs) in txn - MSTCheckRule-blocked SQL (SHOW/DESCRIBE/information_schema) in MST - Allowed operations (USE CATALOG/SCHEMA) in MST - DML variants: executemany, parameterized, DELETE, mixed DML in txn - Concurrent transactions: write conflict, write skew, repeatable reads - Multiple cursors in single transaction - Connection close with pending transaction (implicit rollback) - DDL behavior in transactions (CREATE/DROP/ALTER TABLE) - Edge cases: empty txn, read-only, atomicity, rollback recovery, MERGE Unit tests (test_client.py): - executemany error propagation in transaction context - Cursor close does not affect transaction state - Autocommit toggle consistency Co-authored-by: Isaac Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
85e92e1 to
c5a2e80
Compare
Co-authored-by: Isaac Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_transactions.pyand 3 new unit tests totest_client.pycovering gaps identified in the MST + xDBC Metadata RPCs auditTest plan
pytest tests/unit/test_client.py -k Transaction— 25 tests pass (verified)pytest tests/e2e/test_transactions.py -p no:skipagainst MST-enabled warehouseNO_CHANGELOG=true
This pull request was AI-assisted by Isaac.