src/Appwrite/Utopia/Response/Filters/V21.php (1)

55-64: Misleading comment and potential over-application of transformation.

The comment on line 57 mentions "httpUser, httpPass, store removed" but no corresponding unset() calls exist—these are handled at the model level (see PlatformApp::filter()), not in this filter.

Additionally, parsePlatform() is applied uniformly to both MODEL_PLATFORM_WEB and MODEL_PLATFORM_APP items. Web platforms don't have an identifier field (they use hostname), so the identifier -> key mapping only applies to app platforms. The null coalescing handles this gracefully, but consider:

1. Removing or correcting the misleading comment
2. Adding a brief comment explaining the null coalescing handles platform type differences

📝 Suggested clarification

 protected function parsePlatform(array $content): array
 {
-    // httpUser, httpPass, store removed
-
-    // identifier -> key
+    // Map 'identifier' back to 'key' for backward compatibility.
+    // App platforms have 'identifier'; web platforms don't, so we fallback to existing 'key'.
     $content['key'] = $content['identifier'] ?? $content['key'] ?? null;
     unset($content['identifier']);

     return $content;
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Utopia/Response/Filters/V21.php` around lines 55 - 64, Update
parsePlatform() in V21.php to remove or correct the misleading "httpUser,
httpPass, store removed" comment (those unsets are done in
PlatformApp::filter()), and replace it with a brief note that the
identifier->key mapping uses null coalescing to safely handle both
MODEL_PLATFORM_APP (which may have identifier) and MODEL_PLATFORM_WEB (which
uses hostname), so no additional unsets are required; reference parsePlatform()
and PlatformApp::filter() in the comment for clarity.

src/Appwrite/Utopia/Database/Validator/Queries/Platforms.php (1)

11-11: Address the TODO comment for API consistency.

The TODO indicates that the API should name this field identifier instead of key. This should be tracked and addressed before the API becomes public to avoid breaking changes later.

Would you like me to open an issue to track this API naming inconsistency?

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Utopia/Database/Validator/Queries/Platforms.php` at line 11,
Change the API field name from 'key' to 'identifier' in the Platforms validator
by replacing the string 'key' in Validator/Queries/Platforms.php and then update
all related spots that reference this symbol: validation rules, DTOs/models,
serializers, database schema/migrations, unit/integration tests, and API docs.
To avoid breaking consumers, add a backward-compatible normalization step (e.g.,
in the request normalization or a function like normalizePlatformInput) that
accepts the deprecated 'key' and maps it to 'identifier' while emitting a
deprecation warning/log, and include a migration note and test that both 'key'
(deprecated) and 'identifier' are accepted until the old name is removed.

src/Appwrite/Utopia/Request/Filters/V21.php (1)

14-38: Add regression coverage for the new platform V21 mappings.

This switch now defines the backward-compatibility contract for platform create/update/list requests, and the PR objective says no tests were added yet. A small matrix around platformId defaulting, key → identifier, store stripping, and the default queries branch would catch most regressions here.

Also applies to: 93-121

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Utopia/Request/Filters/V21.php` around lines 14 - 38, Add
regression tests covering the V21 platform mappings: for
project.createWebPlatform/project.createAppPlatform and
project.updateWebPlatform/project.updateAppPlatform ensure fillPlatformId
behavior (platformId defaulting), that 'store' is removed, and 'key' is migrated
to 'identifier' (including when identifier already exists). Also add tests for
project.listPlatforms to assert preservePlatformsQueries behavior for default
queries. Target the code paths that invoke fillPlatformId and
preservePlatformsQueries so changes to those methods or these switch cases will
be caught.

src/Appwrite/Platform/Modules/Project/Http/Project/Platforms/Get.php (1)

76-84: Avoid using the Create actions as the platform-type registry.

Get now depends on Web\Create::getSupportedTypes() / App\Create::getSupportedTypes(), while PlatformWeb and PlatformApp already keep their own lists. If one copy changes without the others, a valid platform can start failing here with GENERAL_UNKNOWN. Please move this mapping behind a shared helper or the response models.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Platform/Modules/Project/Http/Project/Platforms/Get.php` around
lines 76 - 84, The Get handler currently uses
WebPlatformCreate::getSupportedTypes() and
AppPlatformCreate::getSupportedTypes() to decide the response model, which
duplicates the platform-type registry and risks drift; replace that dependency
with the canonical source (PlatformWeb and PlatformApp) or a new shared
registry/helper: call PlatformWeb::getSupportedTypes() and
PlatformApp::getSupportedTypes() (or create a
PlatformTypes::getWebTypes()/getAppTypes() helper and use it here) and map those
results to Response::MODEL_PLATFORM_WEB / Response::MODEL_PLATFORM_APP, throwing
the same Exception only if the type is absent from the shared registry.

src/Appwrite/Platform/Modules/Project/Http/Project/Platforms/XList.php (1)

56-69: Parameter name inconsistency: total vs $includeTotal.

The param is defined as total on line 56, but the action method parameter is $includeTotal on line 69. While the framework likely handles this mapping, maintaining consistent naming improves readability.

♻️ Suggested rename for consistency

-    ->param('total', true, new Boolean(true), 'When set to false, the total count returned will be 0 and will not be calculated.', true)
+    ->param('includeTotal', true, new Boolean(true), 'When set to false, the total count returned will be 0 and will not be calculated.', true)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Platform/Modules/Project/Http/Project/Platforms/XList.php`
around lines 56 - 69, Rename the action method parameter to match the declared
param name to improve clarity: change the method signature in XList::action to
use $total (or alternatively rename the param declaration from 'total' to
'includeTotal') so both sides match; update all uses inside the action()
implementation to reference the chosen name (e.g., XList::action(array $queries,
bool $total, ...)) and ensure dependency injection mapping via ->param('total',
...) stays consistent with this identifier.

src/Appwrite/Platform/Modules/Project/Http/Project/Platforms/App/Create.php (1)

1-1: Consider adding strict type declaration.

Per coding guidelines, strict type declarations should be used where applicable. Adding declare(strict_types=1); after the opening PHP tag improves type safety.

Suggested change

 <?php
+
+declare(strict_types=1);

 namespace Appwrite\Platform\Modules\Project\Http\Project\Platforms\App;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Platform/Modules/Project/Http/Project/Platforms/App/Create.php`
at line 1, Add a strict types declaration to the PHP file by inserting
declare(strict_types=1); immediately after the opening <?php tag in Create.php
so the Create class and its functions enforce strict typing; ensure it appears
before any namespace or use statements to comply with PHP requirements.

src/Appwrite/Utopia/Response/Model/PlatformApp.php (2)

78-82: Fix incorrect PHPDoc comment.

The PHPDoc says "Get Collection" but this is the filter() method that transforms document attributes.

     /**
-     * Get Collection
+     * Filter document attributes for API response.
      *
-     * `@return` Document
+     * `@param` Document $document
+     * `@return` Document The filtered document
      */
     public function filter(Document $document): Document

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Utopia/Response/Model/PlatformApp.php` around lines 78 - 82, The
PHPDoc above the filter() method is incorrect; replace the description "Get
Collection" with a correct summary like "Filter/transform document attributes"
(or similar) and ensure the PHPDoc accurately describes the filter(Document
$document): Document behavior and return type Document to match the method
signature; update any param/return annotations to reference Document and briefly
state that this method maps/transforms document attributes before returning.

---

1-8: Consider adding strict type declaration.

Similar to PlatformBase, this file would benefit from declare(strict_types=1);.

 <?php
+
+declare(strict_types=1);

 namespace Appwrite\Utopia\Response\Model;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Utopia/Response/Model/PlatformApp.php` around lines 1 - 8, Add a
strict types declaration to this file by inserting declare(strict_types=1);
immediately after the opening <?php tag and before the namespace declaration so
PlatformApp uses strict typing like PlatformBase; update the top of
src/Appwrite/Utopia/Response/Model/PlatformApp.php to include this declaration
to enforce strict scalar type checks for the model code (e.g., class symbols in
this file such as the PlatformApp model).

src/Appwrite/Utopia/Response/Model/PlatformWeb.php (1)

1-7: Consider adding strict type declaration.

 <?php
+
+declare(strict_types=1);

 namespace Appwrite\Utopia\Response\Model;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Utopia/Response/Model/PlatformWeb.php` around lines 1 - 7, Add a
strict types declaration to this PHP file by inserting declare(strict_types=1);
immediately after the opening <?php tag in
src/Appwrite/Utopia/Response/Model/PlatformWeb.php so the file (and the
PlatformWeb class and any functions/methods within) will enforce strict typing
at runtime.

src/Appwrite/Utopia/Response/Model/PlatformBase.php (1)

1-6: Consider adding strict type declaration.

The file is missing declare(strict_types=1); which is recommended per coding guidelines for PHP files where applicable.

 <?php
+
+declare(strict_types=1);

 namespace Appwrite\Utopia\Response\Model;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Utopia/Response/Model/PlatformBase.php` around lines 1 - 6, Add
a strict types declaration to this PHP file by inserting
declare(strict_types=1); immediately after the opening <?php tag in
src/Appwrite/Utopia/Response/Model/PlatformBase.php so that the namespace
Appwrite\Utopia\Response\Model and the Model/PlatformBase class (or any
functions/types in this file) are evaluated under strict typing rules.

src/Appwrite/Utopia/Response/Model/PlatformWeb.php (1)

1-8: Add declare(strict_types=1); to the new response model.

This class introduces typed methods on a new public model, so it should opt into strict typing at the file boundary.

♻️ Suggested change

 <?php
+
+declare(strict_types=1);
 
 namespace Appwrite\Utopia\Response\Model;

As per coding guidelines, **/*.php: Use strict type declarations where applicable.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Utopia/Response/Model/PlatformWeb.php` around lines 1 - 8, Add a
strict types declaration to the new response model file by inserting
declare(strict_types=1); immediately after the opening <?php tag in the file
containing the class PlatformWeb (the PlatformWeb class file that extends
PlatformBase), so the file opts into strict typing for its typed public methods.

app/init/models.php (1)

337-339: Please add one regression test around the split platform registrations.

These registrations are now the wiring that makes mixed platforms lists resolve to PlatformWeb vs PlatformApp. A small serialization/spec test with one web platform and one app platform would protect the new public contract from drifting.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@app/init/models.php` around lines 337 - 339, Add a regression test that
asserts mixed platform entries deserialize/resolve to the correct concrete
models: ensure Response::setModel registrations for PlatformWeb, PlatformApp,
and PlatformList continue to split mixed "platforms" lists into PlatformWeb vs
PlatformApp instances; create a spec that serializes a payload with one web
platform and one app platform, runs the same parsing/resolution used by the
application, and asserts the resulting collection contains one PlatformWeb and
one PlatformApp (use the same factory/parse method your app uses to ensure the
public contract is exercised).

src/Appwrite/Utopia/Response/Model/PlatformApp.php (2)

1-9: Add declare(strict_types=1); here too.

This is another new typed model file, so it should follow the same strict-typing boundary as the rest of the PHP surface.

♻️ Suggested change

 <?php
+
+declare(strict_types=1);
 
 namespace Appwrite\Utopia\Response\Model;

As per coding guidelines, **/*.php: Use strict type declarations where applicable.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Utopia/Response/Model/PlatformApp.php` around lines 1 - 9, This
PHP model file is missing the strict types declaration; add
declare(strict_types=1); as the first statement after the opening <?php tag in
the file that defines the PlatformApp class (class PlatformApp extends
PlatformBase) so the file follows the project's strict-typing guideline.

---

78-83: Fix the filter() PHPDoc.

The current block still says Get Collection, which no longer describes this method and omits the $document parameter.

♻️ Suggested change

-    /**
-     * Get Collection
-     *
-     * `@return` Document
-     */
+    /**
+     * Normalize app platform documents for the public API response.
+     *
+     * `@param` Document $document
+     *
+     * `@return` Document
+     */

As per coding guidelines, **/*.php: Include comprehensive PHPDoc comments.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Utopia/Response/Model/PlatformApp.php` around lines 78 - 83,
Update the PHPDoc for the method filter(Document $document): Document to
accurately describe its behavior (it filters/transforms a Document) and add the
missing `@param` annotation for $document with the Document type and a brief
description plus a clear `@return` Document description; locate the PHPDoc
immediately above the filter(Document $document): Document method and replace
the incorrect "Get Collection" summary with a concise description and the two
annotations.

src/Appwrite/Platform/Modules/Project/Http/Project/Platforms/XList.php (3)

27-30: Add return type declaration to getName() method.

The method lacks a return type declaration. For consistency with strict typing practices:

Proposed fix

-    public static function getName()
+    public static function getName(): string
     {
         return 'listProjectPlatforms';
     }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Platform/Modules/Project/Http/Project/Platforms/XList.php`
around lines 27 - 30, The getName() method in class XList currently lacks a
return type; update the method signature for getName() to declare a string
return type (i.e., ensure getName(): string) so it consistently enforces strict
typing and returns 'listProjectPlatforms' as before.

---

56-57: Parameter name mismatch: total vs $includeTotal.

The param is named 'total' (line 57) but the corresponding action method parameter is $includeTotal (line 70). While the framework may map by position, inconsistent naming reduces readability and maintainability. Consider aligning them:

Option A: Rename the action parameter to match

     public function action(
         array $queries,
-        bool $includeTotal,
+        bool $total,
         Document $project,
         Response $response,
         Database $dbForPlatform,
         Authorization $authorization,
     ) {

Then update the usage on line 110:

-            $total = $includeTotal ? $authorization->skip(fn () => $dbForPlatform->count('platforms', $filterQueries, APP_LIMIT_COUNT)) : 0;
+            $totalCount = $total ? $authorization->skip(fn () => $dbForPlatform->count('platforms', $filterQueries, APP_LIMIT_COUNT)) : 0;

Option B: Rename the param to match

-            ->param('total', true, new Boolean(true), 'When set to false, the total count returned will be 0 and will not be calculated.', true)
+            ->param('includeTotal', true, new Boolean(true), 'When set to false, the total count returned will be 0 and will not be calculated.', true)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Platform/Modules/Project/Http/Project/Platforms/XList.php`
around lines 56 - 57, The declared request parameter name 'total' in XList.php
is inconsistent with the action method parameter $includeTotal; choose one
naming approach and make them match to improve readability: either rename the
action method parameter $includeTotal to $total (in the XList action signature
and all uses, e.g., the place around line 70 and usage around line 110) or
rename the param declaration from 'total' to 'includeTotal' (in the ->param(...)
call that references Platforms::ALLOWED_ATTRIBUTES), ensuring both the param
name and the action method signature are identical and updating any call sites
or docstrings accordingly.

---

65-75: Consider adding return type and comprehensive PHPDoc.

The action method lacks a return type declaration, and the PHPDoc only documents the $queries parameter. For better documentation and type safety, consider expanding:

Proposed enhancement

     /**
      * `@param` array<string> $queries
+     * `@param` bool $includeTotal
+     * `@param` Document $project
+     * `@param` Response $response
+     * `@param` Database $dbForPlatform
+     * `@param` Authorization $authorization
+     * `@return` void
      */
     public function action(
         array $queries,
         bool $includeTotal,
         Document $project,
         Response $response,
         Database $dbForPlatform,
         Authorization $authorization,
-    ) {
+    ): void {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Platform/Modules/Project/Http/Project/Platforms/XList.php`
around lines 65 - 75, The action method in class XList (method name: action) is
missing a return type declaration and has incomplete PHPDoc (only $queries
documented); update the docblock to document all parameters (queries,
includeTotal, project, response, dbForPlatform, authorization) with proper types
(array<string>, bool, Document, Response, Database, Authorization) and add a
precise `@return` annotation for the actual return type, then add the
corresponding PHP return type declaration to the method signature to match the
`@return` (e.g., : Response or : array|Response|null as appropriate) so IDEs and
static analyzers can validate usage.

tests/e2e/Services/Projects/ProjectsBase.php (1)

154-252: Typos in variable names: "Fultter" should be "Flutter".

The variable names contain consistent typos throughout the file:

• $platformFultteriOSId → $platformFlutteriOSId
• $platformFultterAndroidId → $platformFlutterAndroidId
• $platformFultterWebId → $platformFlutterWebId

While this doesn't affect functionality, it reduces code readability. Consider fixing these in a follow-up since they exist throughout the file (including the cached array keys on lines 256-258).

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/e2e/Services/Projects/ProjectsBase.php` around lines 154 - 252, The
variables for Flutter platforms contain typos—rename $platformFultteriOSId,
$platformFultterAndroidId, and $platformFultterWebId to $platformFlutteriOSId,
$platformFlutterAndroidId, and $platformFlutterWebId respectively, and update
every usage (including the cached array keys mentioned around the later block)
to use the corrected names so references like the POST response assignments and
any subsequent reads use the new identifiers consistently.

src/Appwrite/Platform/Modules/Project/Http/Project/Platforms/Web/Create.php (1)

1-27: Missing strict type declaration.

PSR-12 recommends using strict type declarations for PHP files. Consider adding declare(strict_types=1); after the opening PHP tag.

Additionally, the class extends Appwrite\Platform\Modules\Compute\Base (line 8) but this is a Project module endpoint. Verify this is the intended base class, as it may be more appropriate to extend a base class from the Project module for consistency.

🛠️ Suggested improvement

 <?php
+
+declare(strict_types=1);

 namespace Appwrite\Platform\Modules\Project\Http\Project\Platforms\Web;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Platform/Modules/Project/Http/Project/Platforms/Web/Create.php`
around lines 1 - 27, Add a strict types declaration by inserting
declare(strict_types=1); immediately after the opening <?php tag in this file,
and verify the class inheritance: the Create class currently extends
Appwrite\Platform\Modules\Compute\Base (imported as Base) which looks incorrect
for a Project module endpoint — either change the use/import to the Project
module base (e.g., Appwrite\Platform\Modules\Project\Base) and update the class
extends accordingly, or confirm that Compute\Base is intentional and
remove/adjust the misleading import/comment; ensure any related use statements
(use Appwrite\Platform\Modules\Compute\Base) are updated to match the chosen
base.

tests/e2e/Services/Projects/ProjectsConsoleClientTest.php (1)

3754-4525: Extract platform legacy headers to a helper to reduce drift.

The same legacy header block is repeated many times; a small helper will reduce copy/paste errors and make future response-format migrations safer.

Refactor sketch

+    private function platformHeaders(bool $legacy = true): array
+    {
+        return array_merge([
+            'content-type' => 'application/json',
+            'x-appwrite-project' => $this->getProject()['$id'],
+        ], $legacy ? [
+            'x-appwrite-response-format' => '1.8.0',
+        ] : [], $this->getHeaders());
+    }

Then replace repeated array_merge([...], $this->getHeaders()) blocks in platform tests with platformHeaders().

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/e2e/Services/Projects/ProjectsConsoleClientTest.php` around lines 3754
- 4525, Extract the repeated legacy header array_merge([...],
$this->getHeaders()) into a helper method (e.g., platformHeaders()) in this test
class and replace each occurrence in platform-related tests (methods like
setupProjectWithPlatform(), setupProjectData(), testListProjectPlatform(),
testGetProjectPlatform(), testUpdateProjectPlatform(),
testDeleteProjectPlatform()) with a call to platformHeaders(); implement
platformHeaders() to accept an optional array of overrides (merge defaults like
'content-type','x-appwrite-project','x-appwrite-response-format' with
$this->getHeaders() and any passed overrides) so every client->call uses
platformHeaders() instead of duplicating the array_merge.

src/Appwrite/Platform/Modules/Project/Http/Project/Platforms/App/Create.php (2)

1-2: Add strict type declaration.

Per coding guidelines, PHP files should use strict type declarations where applicable.

 <?php
+
+declare(strict_types=1);
 
 namespace Appwrite\Platform\Modules\Project\Http\Project\Platforms\App;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Platform/Modules/Project/Http/Project/Platforms/App/Create.php`
around lines 1 - 2, This PHP file is missing a strict types declaration; add
declare(strict_types=1); immediately after the opening <?php tag in src Appwrite
Platform Modules Project Http Project Platforms App Create.php (the file
containing the Create class) so the Create class and any functions in this file
are evaluated under strict typing rules.

---

31-34: Add return type declaration.

The getName() method should have a return type hint for PSR-12 compliance.

-    public static function getName()
+    public static function getName(): string
     {
         return 'createProjectAppPlatform';
     }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Platform/Modules/Project/Http/Project/Platforms/App/Create.php`
around lines 31 - 34, The getName() method lacks a return type declaration;
update the public static function getName() in the Create class to declare and
return a string (add a ": string" return type) so it matches PSR-12 and
accurately types the returned value 'createProjectAppPlatform'.