fix(sqllab): long cell content overflooding#38855
fix(sqllab): long cell content overflooding#38855justinpark wants to merge 1 commit intoapache:masterfrom
Conversation
Code Review Agent Run #5da378Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
Sequence DiagramThis PR makes JSON trigger text wrapping configurable in JsonModal and disables wrapping for SQL Lab result cells. The main flow now renders JSON cell previews without pre wrap, preventing overlap while preserving modal preview behavior. sequenceDiagram
participant User
participant ResultTable
participant JsonModal
User->>ResultTable: View SQL Lab results
ResultTable->>ResultTable: Detect JSON cell content
ResultTable->>JsonModal: Render JSON trigger with wrapContent false
JsonModal->>JsonModal: Show trigger text without pre wrap
User->>JsonModal: Open cell content modal
JsonModal-->>User: Display formatted JSON content
Generated by CodeAnt AI |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
User description
SUMMARY
Fixes #38854
Due to the pre-wrap added in #37036, an issue occurred where the SQL Lab result table cell content supporting the JSON viewer was overlapping with the content of the next line. This has been fixed by making pre-wrap configurable as a props option, so that pre-wrap is excluded for the result table.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
locally tested
ADDITIONAL INFORMATION
CodeAnt-AI Description
Prevent JSON cell content from overflowing in SQL Lab results
What Changed
Impact
✅ Clearer SQL Lab result tables✅ Fewer overlapping cell contents✅ Easier reading of long JSON values💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.