Skip to content

docs: remove private utils from testing skills#67880

Merged
pkozlowski-opensource merged 1 commit intoangular:mainfrom
cexbrayat:fix/skills-testing
Mar 26, 2026
Merged

docs: remove private utils from testing skills#67880
pkozlowski-opensource merged 1 commit intoangular:mainfrom
cexbrayat:fix/skills-testing

Conversation

@cexbrayat
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The testing skills promotes the usage of internal APIs

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I would also not promote changing the component instance directly component.title.set('...') but rather interact with the DOM to trigger the change with button.click() for example.

@pullapprove pullapprove bot requested a review from kirjs March 26, 2026 08:04
@angular-robot angular-robot bot added the area: docs Related to the documentation label Mar 26, 2026
@ngbot ngbot bot added this to the Backlog milestone Mar 26, 2026
@JeanMeche JeanMeche removed the request for review from kirjs March 26, 2026 11:09
@pullapprove pullapprove bot requested a review from kirjs March 26, 2026 11:09
@JeanMeche JeanMeche requested review from MarkTechson and atscott and removed request for kirjs March 26, 2026 11:09
Copy link
Contributor

@MarkTechson MarkTechson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 26, 2026
@JeanMeche JeanMeche removed the request for review from atscott March 26, 2026 15:56
@pkozlowski-opensource pkozlowski-opensource merged commit 9bb1e78 into angular:main Mar 26, 2026
24 checks passed
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants